Skip to content

Add Windows menu and dock layout presets to Run View#2512

Merged
Mbeaulne merged 1 commit into
masterfrom
run-v2-default-window-layout
Jul 15, 2026
Merged

Add Windows menu and dock layout presets to Run View#2512
Mbeaulne merged 1 commit into
masterfrom
run-v2-default-window-layout

Conversation

@Mbeaulne

@Mbeaulne Mbeaulne commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Description

Introduces a Windows menu to the Run View menu bar, allowing users to toggle the visibility of individual windows and apply layout presets. A new runViewWindowPresets.ts module centralizes window IDs and defines the available presets:

  • Default: Run Tools and AI Assistant docked on the left, Run Details docked on the right.
  • Minimal: All panels hidden.

Window IDs for Run Tools, Run Details, and AI Assistant are now exported from a single source of truth, replacing previously scattered local constants. Each window is assigned a defaultDockState so they snap to their intended dock side on first open.

A DockArea for the left side is added to the Run View layout to support docked windows.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Open a run in the Run View.
  2. Confirm the Windows menu appears in the menu bar.
  3. Toggle individual windows on/off via the Windows menu and verify visibility changes.
  4. Open the Views submenu and apply the Default preset — Run Tools and AI Assistant should dock to the left, Run Details to the right.
  5. Apply the Minimal preset and confirm all panels are hidden.

Additional Comments

Tests for the preset logic are included in runViewWindowPresets.test.ts, covering both the default docking layout and the minimal hide-all behavior.

@Mbeaulne
Mbeaulne requested a review from a team as a code owner July 13, 2026 19:30
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: run-v2-default-window-layout/342a3e9

Copy link
Copy Markdown

Question because it has come up x2 times now:

Will any of this work help the existing Tangle users who may have localstorage in an old, not-ideal state?

Both @yuechao-qin and I had to clear our local storage to get the runs V2 page into a usable state. I'm thinking we probably need a programmatic reset for V2 runs page - like a new key in local storage or some form of detection of poor layout configuration with a reset side effect.

Unfortunatley I know longer have my old local storage to say what it looked like

@Mbeaulne
Mbeaulne force-pushed the run-v2-default-window-layout branch 3 times, most recently from 9e22e79 to bbb6714 Compare July 13, 2026 21:10
@Mbeaulne Mbeaulne changed the title Improve Run V2 default window layout Add run view V2 version toggle, routing, and window presets Jul 13, 2026
@Mbeaulne Mbeaulne changed the title Add run view V2 version toggle, routing, and window presets WIP: Add run view V2 version toggle, routing, and window presets Jul 13, 2026
@Mbeaulne
Mbeaulne force-pushed the run-v2-default-window-layout branch from bbb6714 to d2595bb Compare July 13, 2026 21:37
@Mbeaulne Mbeaulne changed the title WIP: Add run view V2 version toggle, routing, and window presets Add Windows menu and dock layout presets to Run View Jul 13, 2026
@Mbeaulne
Mbeaulne force-pushed the run-v2-default-window-layout branch 2 times, most recently from 4a603a5 to c922def Compare July 13, 2026 22:25
Comment thread src/routes/v2/shared/windows/windowStore.utils.ts Outdated
@Mbeaulne
Mbeaulne force-pushed the run-v2-default-window-layout branch from c922def to 0e16bac Compare July 14, 2026 18:23
@Mbeaulne

Copy link
Copy Markdown
Collaborator Author

@morgan-wowk Yes — this now uses a new runview-v2 persistence ID. Existing window-layout-runview data is ignored, giving users a one-time reset to the new usable defaults without requiring them to clear local storage manually. New Run View customizations persist under window-layout-runview-v2.

Mbeaulne commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Merge activity

  • Jul 15, 5:17 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 15, 5:18 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 15, 5:21 PM UTC: @Mbeaulne merged this pull request with Graphite.

@Mbeaulne
Mbeaulne force-pushed the run-v2-default-window-layout branch from 53f7109 to 342a3e9 Compare July 15, 2026 17:17
@Mbeaulne
Mbeaulne merged commit fc96693 into master Jul 15, 2026
17 checks passed
@Mbeaulne
Mbeaulne deleted the run-v2-default-window-layout branch July 15, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants