Add optional targetCluster to pipeline submission - #2587
Draft
morgan-wowk wants to merge 1 commit into
Draft
Conversation
submitPipelineRun gains an optional targetCluster; when set it adds the cloud-pipelines.net/orchestration/target_cluster run annotation the backend router uses to pick the execution cluster. When unset the run payload is byte-identical to today, so default routing is unaffected. The annotation key is centralized in src/utils/annotations.ts.
🎩 PreviewA preview build has been created at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
targetClustertosubmitPipelineRun. When set, it adds the run annotationcloud-pipelines.net/orchestration/target_cluster, which the backend launcher router uses to pick which GKE execution cluster the run lands on. When unset, the run payload is byte-identical to today.Why
Part of the eo9 execution migration. The backend (oasis-backend) routes a run to the "next" GKE cluster when this annotation matches
GKE_CLUSTER_ID_NEXT; otherwise default routing is unchanged. This PR is the plumbing — it does not yet surface a picker (that's the stacked follow-up). The annotation key is centralized insrc/utils/annotations.ts(ORCHESTRATION_TARGET_CLUSTER_ANNOTATION) to avoid drift with the backend constant.Changes
src/utils/annotations.ts:ORCHESTRATION_TARGET_CLUSTER_ANNOTATIONconstant.src/utils/submitPipeline.ts: optionaltargetClusteroption, conditionally spread intopayload.annotations.Tests
submitPipeline.test.ts: annotation present whentargetClusterset; run annotations{ source: "web-app" }unchanged when unset. Full suite (31) green;tsc --noEmit, eslint, prettier clean.Draft — Stack C1 of the eo9 execution migration; the submit-dialog cluster picker stacks on top.