Skip to content

feat: run comparison - compare page, run selection & routing - #2603

Draft
camielvs wants to merge 1 commit into
cmp-07-graph-diff-viewfrom
cmp-08-compare-page-and-wiring
Draft

feat: run comparison - compare page, run selection & routing#2603
camielvs wants to merge 1 commit into
cmp-07-graph-diff-viewfrom
cmp-08-compare-page-and-wiring

Conversation

@camielvs

@camielvs camielvs commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Description

Final PR in the Compare Runs stack — this is the one that turns all the previous pieces into a usable feature.

  • Adds the Compare page (/compare) that ties everything together: a header with both runs (labelled A/B, swap, share-link and close), the run metadata bar, and the Structured / YAML / Graph tabs.
  • Adds the ways to get there:
    • Dashboard run list — checkboxes on each row; selecting exactly two runs shows a "Compare" action bar.
    • Run view menu — a "Compare with another run…" item that pre-fills that run as side A.
  • If you land on /compare without both runs chosen, it shows a run picker for the missing side (and guards against comparing a run with itself).
  • Everything is gated behind a new compare-runs beta flag — the route redirects away and the entry points stay hidden when it's off.

Also moves the shared buildTaskExecutionStatusMap helper into utils/executionStatus (used by both the run view and the comparison).

Related Issue and Pull requests

Final PR in the Compare Runs stack. Builds on #2602 (#2596#2603).

Type of Change

  • New feature

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Enable the Compare runs flag under Settings → Beta features.
  2. From the dashboard: select exactly two runs with the row checkboxes — a Compare bar appears at the bottom. Click Compare.
  3. From a run: open a run's menu and choose Compare with another run…, then pick a second run.
  4. On the compare page, confirm:
    • The header shows both runs (A/B); swap flips them, share copies the URL, close returns to the run list.
    • The Structured, YAML and Graph tabs all work.
    • Opening the page URL directly (with ?a=…&b=…) loads the same comparison; picking the same run twice is blocked.
  5. Flag off: confirm the checkboxes, compare bar and run-menu item disappear, and visiting /compare redirects to the run list.
  6. Regression: open a normal run view and confirm task statuses still render (the buildTaskExecutionStatusMap move).

Additional Comments

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: cmp-08-compare-page-and-wiring/89ec2e4

camielvs commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator Author

@camielvs
camielvs force-pushed the cmp-07-graph-diff-view branch from e34d81d to 22f985a Compare July 30, 2026 23:22
@camielvs
camielvs force-pushed the cmp-08-compare-page-and-wiring branch 2 times, most recently from 091c054 to 8d790d4 Compare July 31, 2026 00:24
@camielvs
camielvs force-pushed the cmp-07-graph-diff-view branch 2 times, most recently from a1c4ec9 to 69226d7 Compare July 31, 2026 01:05
@camielvs
camielvs force-pushed the cmp-08-compare-page-and-wiring branch from 8d790d4 to 357bd26 Compare July 31, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant