Add opt-in single-node Kubernetes Jobs#299
Draft
nateGeorge wants to merge 1 commit into
Draft
Conversation
Let hybrid Kubernetes launchers select a NonIndexed Job for single-node tasks while keeping direct Pods as the default and preserving Indexed Jobs for multi-node tasks. Co-authored-by: AI (Pi/GPT-5.6 Sol) <noreply@pi.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in NonIndexed Job mode for single-node tasks while keeping direct Pods as the default and preserving existing Indexed Job behavior for multi-node tasks.
This is a follow-up to #298 and must merge after it. Launcher defaults can select
podorjob, individual tasks can override the single-node mode with an annotation, and multi-node annotations always take precedence.Testing
uv run --frozen black --check --fast cloud_pipelines_backend/launchers/kubernetes_launchers.py cloud_pipelines_backend/launchers/google_kubernetes_launchers.py tests/test_kubernetes_launchers.pyPYTHONPATH=. uv run --frozen pytest -q tests/test_kubernetes_launchers.py tests/test_skypilot_launchers.py— 35 passedPYTHONPATH=. uv run --frozen pytest -q— 449 passed, 13 warningsgit diff --check