Favorites: o opens an exact favorite directly#61
Merged
Conversation
Applying a favorite only set it as the prefix filter, costing an extra keypress for the common case of jumping into one data set. The popup's o action runs the same jump fetch with the data set queued for auto-open: when the listing lands, the row is selected and the normal openSelection path runs, so PS/PO routing, the migrated-recall suggestion, and usage tracking all apply unchanged. A favorite whose data set no longer exists warns instead of opening; pattern favorites have nothing unambiguous to open and degrade to the filter jump. Closes #57 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CS2LZMn2YJdebAiry2jzdP
The queue was consumed by whichever data set listing next passed acceptBrowse: a prefix change, refresh, or back-navigation issued between pressing o and the listing landing could fire the stale open against an unrelated listing (or emit a spurious not-found warning), and a zero-budget jump armed the queue with no fetch at all. The queue now carries the browse generation that armed it — results from any other generation clear it without firing — and only arms when the jump actually dispatched. A listing that lands for a backgrounded profile selects the favorite's row instead of dropping the open silently. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CS2LZMn2YJdebAiry2jzdP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57. Stacked on #60 → #59 → #55…; retarget as the chain merges.
oin the favorites popup opens the selected favorite instead of only filtering by it:workspace.autoOpen; when the data set listing lands, the row is selected (pager.selectKey) and the standardopenSelectionpath runs — so PS goes to records, PO/PO-E to the member list, a migrated data set gets the press-R-to-recall suggestion, unsupported DSORGs warn, and the Local usage tracking: data set opens and executed jq queries #58 usage log records the open, all through the one code path.o(nothing unambiguous to open);enterjump is unchanged.Tests cover the direct open (screen, fetched records, MRU touch), the missing-data-set warning, the pattern degradation, and the migrated-recall suggestion. Demo-mode terminal run confirms
f→F→olands on the records screen with the auto-applied copybook and the open event inevents.jsonl.🤖 Generated with Claude Code
https://claude.ai/code/session_01CS2LZMn2YJdebAiry2jzdP