Allow nullable material on step

[andreia]

Details

Allow nullable material on step.

---

Note

Medium Risk
Includes a schema change to nullable morph columns and corresponding UI/runtime behavior changes; risk is mainly around migration compatibility and ensuring existing steps still render/validate as expected.

Overview
Steps can now be created without an attached material (text-only steps).

This adds a migration to make lms_steps.material_type and material_id nullable and wires it into the package migrations list, updates the material selector form to allow a null material_type while only requiring material_id when a type is chosen, and adjusts the step page to treat material_type = null as an intentional “next-only” step while still showing an error when a type is set but the related material record is missing. The StepFactory gains withoutMaterial() and withText() helpers, and the Step model phpdoc is updated for nullable material fields.

^{Written by Cursor Bugbot for commit cd81152. This will update automatically on new commits. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is ON. A Cloud Agent has been kicked off to fix the reported issues.}

[cursor]

Bugbot Autofix prepared a fix for 2 of the 2 bugs found in the latest run.

• ✅ Fixed: Deleted material silently hidden when step has text
  • Changed logic to check material_type first: null means intentional text-only step, set but with null material means deleted content and error is now shown regardless of text presence.
• ✅ Fixed: Form allows material_type without selecting actual material
  • Changed material_id validation from nullable() to requiredWith('material_type') to ensure material_id is required when material_type is selected.

Or push these changes by commenting:

@cursor push d2b7e39a1c

Preview (d2b7e39a1c)

diff --git a/resources/views/pages/step.blade.php b/resources/views/pages/step.blade.php
--- a/resources/views/pages/step.blade.php
+++ b/resources/views/pages/step.blade.php
@@ -111,23 +111,21 @@
     }
     </style>
 
-    @if (is_null($step->material))
-        @if(!$step->text)
-            {{-- No material and no text: show error --}}
-            <div class="flex items-center justify-center min-h-[60vh]">
-                <x-filament::card class="py-12 w-full max-w-md">
-                    <div class="flex flex-col justify-center items-center text-center">
-                        <div class="mb-4 text-lg font-semibold text-red-600">
-                            The material for this step is missing or has been deleted.
-                        </div>
-                        <x-filament-lms::next-button :fixed="false" />
+    @if (is_null($step->material_type))
+        {{-- Intentionally text-only step: show the next button --}}
+        <x-filament-lms::next-button />
+    @elseif (is_null($step->material))
+        {{-- Material type is set but material is missing (deleted): show error --}}
+        <div class="flex items-center justify-center min-h-[60vh]">
+            <x-filament::card class="py-12 w-full max-w-md">
+                <div class="flex flex-col justify-center items-center text-center">
+                    <div class="mb-4 text-lg font-semibold text-red-600">
+                        The material for this step is missing or has been deleted.
                     </div>
-                </x-filament::card>
-            </div>
-        @else
-            {{-- Text-only step: show the next button --}}
-            <x-filament-lms::next-button />
-        @endif
+                    <x-filament-lms::next-button :fixed="false" />
+                </div>
+            </x-filament::card>
+        </div>
     @elseif ($step->material_type == 'video')
         <livewire:video-step :step="$step"/>
     @elseif ($step->material_type == 'form')

diff --git a/src/Forms/Components/MorphToSelectWithCreate.php b/src/Forms/Components/MorphToSelectWithCreate.php
--- a/src/Forms/Components/MorphToSelectWithCreate.php
+++ b/src/Forms/Components/MorphToSelectWithCreate.php
@@ -62,7 +62,7 @@
                     return $className::query()->pluck('name', 'id');
                 })
                 ->searchable()
-                ->nullable()
+                ->requiredWith('material_type')
                 ->suffixActions([
                     Action::make('create_video')
                         ->label('New')

[andreia]

@cursor push d2b7e39

[cursor]

Could not push Autofix changes. The PR branch may have changed since the Autofix ran, or the Autofix commit may no longer exist.

[swilla]

Scott is good with this approach