keep detail::Join compilable with exceptions disabled - #195
Merged
Conversation
Owner
|
Good catch, and the PR looks good. Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unguarded try/catch in detail::Join
Every other
try/catchin the header sits behind#ifndef ARGS_NOEXCEPT, so-fno-exceptions -DARGS_NOEXCEPTused to build; since the reserve guard landed it stops at args.hxx:401 withcannot use 'try' with exceptions disabled(6.4.16 compiles, 6.5.0 onwards does not). I dropped the guard rather than adding another#ifndef, since it only coversres.reserve(total)while the append loop below allocates the same memory unguarded, so it was not really buying anything.The new
no_exceptionstest is built with exceptions off under both CMake and meson, so it fails to compile on master and passes here; the throwing helpers intest_helpers.hxxhad to move behind__cpp_exceptionsfor it to use them.