fix: add bindings as runtime dependency for Windows packaging#71
Merged
Conversation
Credit: @Deeeemooo (PR #50) Fixes Windows packaged app startup failure: better-sqlite3 loads its native addon via require('bindings')('better_sqlite3.node'), but the packaged app was missing 'bindings'. This caused Murmur.exe to start with no visible window. - Add bindings@^1.5.0 as production dependency - Remove from ghost-dependency test list - Add regression test ensuring bindings stays as direct dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Windows packaged app startup failure caused by missing
bindingsruntime dependency.Credit: @Deeeemooo (original PR #50, recreated from repo branch so CI can validate — fork PRs don't trigger CI).
Problem
When Murmur starts,
better-sqlite3loads its native addon throughrequire('bindings')('better_sqlite3.node'). The packaged Windows app was missingbindings, causing the Electron main process to throw before creating the BrowserWindow. Visible result:Murmur.exestarts but no desktop window appears.Fix
bindings@^1.5.0as a production dependencybindingsfrom the ghost-dependency test list (it was incorrectly flagged as a ghost dep)bindingsstays as a direct dependencyType of Change
Checklist
pnpm testpasses (652 tests)