feat(v2): clarify selected tabs and reopen the guide - #735
Merged
Conversation
lilyshen0722
changed the base branch from
codex/732-create-first-run-ux
to
codex/732-create-first-run-ux-restored
July 23, 2026 08:22
lilyshen0722
force-pushed
the
codex/732-create-first-run-ux
branch
from
July 23, 2026 08:28
5d59e9e to
d873370
Compare
lilyshen0722
changed the base branch from
codex/732-create-first-run-ux-restored
to
main
July 23, 2026 08:38
V2PodsSidebarCreate asserted the pre-grill strings (列入发现后… / 仅限邀请…). The zh-cn-ui-localization polish in #736 changed the locale to 列入「发现」后… / 仅限受邀…, so these assertions broke. #736 merged on a stale CI pass (GitHub tested the pre-polish head after a close/reopen head refresh), leaving main red on this suite; this repairs it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DMeWzgFxsfBcjoLVLewEES
samxu01
force-pushed
the
codex/732-tabs-guide-companion
branch
from
July 23, 2026 08:49
6d0442e to
a1729ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked PR
This companion is intentionally based on #734 head
d8733704because it touchesV2FirstRunHero.tsxandv2.css. The PR targetscodex/732-create-first-run-uxso review shows only F/G. After #734 merges, rebase this branch ontomainand retarget the PR.Root cause
The sidebar's selected state was both visually weak and split across a shared segment class plus a duplicate pod-specific override. The shared rule now owns the treatment for both rows. Its selector includes the v2 root/button scope so the global button reset cannot erase the background, border, or text color.
Verification
cd frontend && npm test -- --watchAll=false --runInBand— 64 suites, 298 testscd frontend && npm run build— passgit diff --check— passrgb(47, 111, 235)background/border, white text, weight 700started=1, and Escape restores focus to the footer actionGuarantee coverage
--v2-accent, rejects--v2-accent-soft, and pins white token-backed text + weight 700Review gate
The only new zh-CN copy is
firstRun.reopen: "指南". Merge remains blocked on Sam's native-speaker review.