Defect repairs #1431
Merged
Defect repairs #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ley et al. 2000, appendix)
…ley et al. 2000, appendix); Changed utils::GetGSLVersion() to avoid compiler warning 'warning: ignoring attributes on template argument ‘int (*)(FILE*)’ [-Wignored-attributes]'; Reverted Makefile line 'SOURCES := ' to listing actual source files
jeffriley
added
bug
ilyamandel
approved these changes
Aug 20, 2025
Collaborator
ilyamandel
left a comment
ilyamandel
left a comment
There was a problem hiding this comment.
Looks great -- thank you, @jeffriley !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ilyamandel for your review
@reinhold-willcox once this is merged with dev can you pull dev, rebuild COMPAS, and tell me if that stray compiler warning you saw the other day has gone away?
Making severity/urgency moderate for the Makefile fix