Nan radius fix #731
Merged
Nan radius fix #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jeffriley
requested changes
Dec 16, 2021
Collaborator
There was a problem hiding this comment.
Looks good. For consistency we should probably used 'std::cbrt' and 'std::sqrt' always (or 'cbrt' and 'sqrt' always), but that's a small point.
Changelog?
EDIT: I just noticed you missed a semi-colon in WhiteDwarfs.cpp, and the compile fails.
And our minimum test is the detailed plot in the examples. Can you run that and check your output against the standard?
Collaborator
Author
|
Woops, that's what I get for trying to code before bed. Yup, on it. |
jeffriley
approved these changes
Dec 16, 2021
Collaborator
jeffriley
left a comment
jeffriley
left a comment
There was a problem hiding this comment.
Did you produce the detailed plot? I'll approve and merge, but I think you should produce the plot just to be sure.
Collaborator
Author
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed calls to PPOW(base, exponent) where exponent was something like 1/2 or 1/3 to sqrt and cbrt. In the current functionality, the 1/3 power was unable to handle negative arguments, even though mathematically this is fine. Cbrt has no issue with negative arguments.