fix(pwa): ship real WordyMe install icons - #104
Merged
Conversation
The manifest pointed at a 100x100 logo declared as `sizes: any`, so every launcher icon and splash screen was upscaled from it and looked soft. The only correctly sized files in public/ were logo192.png and logo512.png, which were still the default React logos left over from scaffolding — and they were being served publicly. Both are now rendered from the brand vector at their true sizes, the Apple touch icon moves from an odd 313px to the standard 180px, and a maskable variant keeps the mark inside the safe zone so Android crops it to the launcher shape instead of letterboxing a transparent logo. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the icons users get when they install WordyMe as an app. The PWA manifest pointed at a 100×100 logo declared as
sizes: 'any', so every launcher icon and splash screen was upscaled from it and looked soft. Meanwhile the only correctly sized files inpublic/—logo192.pngandlogo512.png— were still the default React logos left over from project scaffolding, and were being served publicly at/logo192.pngand/logo512.png. Both are now rendered from the brand vector at their true sizes, and Android gets a proper maskable icon.Related Issues
None — found while producing brand assets for the repository's social preview.
Fixes # — n/a
Type of Change
Bug fix (installed-app branding / PWA asset correctness).
Changes
apps/web/public/logo192.pngandlogo512.png— replaced the stock React logos with the WordyMe mark, rendered from the brand SVG at 192×192 and 512×512.apps/web/public/apple-touch-icon.png— re-rendered at the standard 180×180 (was an odd 313×313).apps/web/public/maskable-512.png— new. Android crops icons to the launcher's shape (circle, squircle, rounded square); this variant keeps the mark inside the safe zone on an opaque background, so the logo is cropped correctly instead of being letterboxed into a white tile.apps/web/vite.config.ts— manifest icons now declare real dimensions (192x192,512x512) with explicitpurpose: 'any', plus themaskableentry; the new files are added toincludeAssetsso they are precached. Comments explain why the sizes must match the files.How to Test
pnpm --filter web build, then inspectapps/web/dist/manifest.webmanifest— theiconsarray listslogo192.png(192x192),logo512.png(512x512), andmaskable-512.png(512x512, maskable).pnpm dev, open devtools → Application → Manifest — all three icons load, no "icon size mismatch" or missing-icon warnings./logo192.pngand/logo512.pngno longer serve the React logo.Expected result: the installed app shows a sharp WordyMe icon at every size, on both Android and iOS, and no React branding is served anywhere.
Screenshots
N/A
Summary by CodeRabbit