Skip to content

fix: fix null-check logic method call error#635

Merged
sjfhsjfh merged 3 commits intoTeamFlos:mainfrom
ljlVink:main
Feb 5, 2026
Merged

fix: fix null-check logic method call error#635
sjfhsjfh merged 3 commits intoTeamFlos:mainfrom
ljlVink:main

Conversation

@ljlVink
Copy link
Contributor

@ljlVink ljlVink commented Jan 9, 2026

In the current mainline version, the pause button displays abnormally (e.g., for ID=16624), and there are rendering glitches in the latter half of the chart. I reverted to the previous code, and it works fine

.extended
.as_ref()
.is_none_or(|it| it.text_events.as_ref().is_some_and(|it| it.is_empty()))
.map_or(true, |it| it.text_events.as_ref().map_or(true, |it| it.is_empty()))

This comment was marked as resolved.

@ljlVink ljlVink requested a review from YuevUwU January 11, 2026 12:01
@YuevUwU
Copy link
Contributor

YuevUwU commented Jan 12, 2026

Extra Info for this PR

Chart ID: #16624 (phira.moe)
Left (main): f15eadb
Right (After this PR): 4a8ea91

Pause Button made by Drag Note Scaling
image

White Block Scaling (Before COMBO 0 or After COMBO 825 or After COMBO 1065+ == near the END)
image

Weird Yellow Block in right-bottom corner (After COMBO 1065+ == near the END)
image

About Review Request

TL;DR, Yeah, it matches what I mentioned in my review. Just have a TeamFlos member review it. I don't believe I'm capable of conducting a formal review/approve. I tried to mark my requested changes as resolved but GitHub don't let me do due to permission.

First, I can't create a valid approving review to let this PR able to merge, which requires the user have write or higher role to this repo [doc]
And I may miss some problem, because I have very little knowledge and playing experience about charts.
So...it would be right if IjlVink didn't find other problem currently.
For the whole repo, I can't guarantee whether Mivik modify the logic in other code and really expected to make it be is_some_and, even if the chance is very small

The mistake is weird because this won't happen after clippy fix automatically on the base 986be9c,
but it's clear to see that Mivik does review each change and then edits it manually.
We may can compare auto-fix and 3b8eb47 , optionally use difftastic for structural diff support, and redirect stdout to file or add GIT_PAGER=cat to see in terminal with color.
I have done it but I didn't find any other problem.

@sjfhsjfh sjfhsjfh merged commit 61ca1ff into TeamFlos:main Feb 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants