Skip to content

feat: 위시 접근 로그인 화면에서 비회원 로그인 버튼 숨김 - #513

Open
iOdiO89 wants to merge 1 commit into
devfrom
feat/490-hide-guest-login
Open

feat: 위시 접근 로그인 화면에서 비회원 로그인 버튼 숨김#513
iOdiO89 wants to merge 1 commit into
devfrom
feat/490-hide-guest-login

Conversation

@iOdiO89

@iOdiO89 iOdiO89 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

작업 요약

  • 위시 접근 경로로 진입한 로그인 화면에서 비회원으로 시작하기 버튼을 숨깁니다.

작업 세부 내용

게스트는 위시를 저장·조회할 수 없는데, 위시 접근 시 뜨는 로그인 화면에도 비회원으로 시작하기 버튼이 그대로 노출되어 눌러도 의미가 없었습니다.

진입 경로 판별

위시 진입 화면(WishLoginRequired)은 getLoginPath(ROUTES.WISHLIST) 로 로그인 페이지에 보내므로, redirect 쿼리가 회원 전용 경로인지로 판별합니다. getPostLoginRedirectPath 가 이미 쓰고 있는 방식(쿼리 제거 후 getRouteType)을 그대로 재사용했습니다.

/** 회원 전용 경로(위시 등)로 진입 시 게스트 로그인은 의미가 없어 미노출 */
const isMemberOnlyRedirect =
  !!validRedirect && getRouteType(validRedirect.split('?')[0] ?? validRedirect) === 'MEMBER_ONLY';

위시 경로를 하드코딩하지 않아 MEMBER_ONLY 라우트 전체(/wishlist, /mypage/withdraw, /tournament/history)에 동일하게 적용됩니다. 이 경로들은 게스트로 로그인해도 어차피 홈으로 돌려보내므로 버튼을 숨기는 취지에 맞습니다.

자리 유지

레이아웃이 흔들리지 않아야 하므로 조건부 렌더 대신 invisible(visibility: hidden)로 숨깁니다. mt-7 포함 공간은 그대로 유지되고, 클릭·탭 포커스·접근성 트리에서는 자연스럽게 빠집니다.

className={cn(
  'mt-7 flex cursor-pointer items-center gap-1.5 ...',
  /** 레이아웃이 흔들리지 않도록 자리는 유지한 채 숨김 */
  isMemberOnlyRedirect && 'invisible'
)}

스크린샷

2026-08-13.10.29.36.mov

연관 이슈

closes #490

@iOdiO89 iOdiO89 self-assigned this Aug 13, 2026
@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
piki Ready Ready Preview Aug 13, 2026 1:33am

@github-actions
github-actions Bot requested a review from soyeong0115 August 13, 2026 01:33
@github-actions

Copy link
Copy Markdown

Discord 스레드 연동용 메타데이터입니다. discord-pr-bot 워크플로가 자동 생성하며, 수정·삭제하면 PR 과 Discord 알림 연동이 끊깁니다.

@github-actions github-actions Bot added feature New feature or request WEB labels Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@iOdiO89, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: efa10c52-541d-4a89-b2f9-29afb33860bb

📥 Commits

Reviewing files that changed from the base of the PR and between 697297a and 371aa60.

📒 Files selected for processing (1)
  • apps/web/src/app/login/_components/LoginButtons.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@iOdiO89

iOdiO89 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 31 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request WEB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: 위시 접근 로그인 화면에서 비회원 로그인 버튼 숨김

1 participant