docs: complete the hero samples; own the TypedActivity portability boundary - #3
Merged
Conversation
…undary Both hero snippets used callActivity and workflowBundle without importing them, and the README hero used Charge/ManagerApproval without defining them (caught by Michael Arnaldi). Both are now self-consistent, compilable-shaped samples. activities.md gains a portability note stating plainly what is engine-agnostic (workflow definitions, upstream Activity.make as an in-sandbox seam) and what is Temporal-shaped (TypedActivity/callActivity), and why: Temporal runs activities on a separate worker that upstream's closure-carried Activity implementations cannot reach, so a serializable name+schema projection is forced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two pieces of feedback from Michael Arnaldi:
callActivitywas never imported in the home-page sample — both hero snippets (docs landing + README) usedcallActivityandworkflowBundlewithout importing them, and the README hero usedCharge/ManagerApprovalwithout defining them. Both are now self-consistent samples.TypedActivity/callActivityare Temporal-shaped because Temporal executes activities on a separate worker that upstream's closure-carriedActivity.makeimplementations cannot reach — a name+schema projection is the serializable form that boundary forces. The deeper design response (an engine-agnostic dispatch seam, or an upstream schema'd activity primitive) is a separate conversation.🤖 Generated with Claude Code