Skip to content

ci: move off deprecated node20 actions, single-source the Go version - #116

Merged
ripexz merged 2 commits into
masterfrom
workflow-updates
Jul 14, 2026
Merged

ci: move off deprecated node20 actions, single-source the Go version#116
ripexz merged 2 commits into
masterfrom
workflow-updates

Conversation

@ripexz

@ripexz ripexz commented Jul 14, 2026

Copy link
Copy Markdown
Member

GitHub is deprecating the node20 Actions runtime. This moves every affected action off it, and removes a version-duplication papercut while in there.

Changes

  • node20 → node24. Checked the runs.using: each pinned action actually declares (rather than inferring from version numbers). The lint/test actions were already on node24; all five Docker actions in the build job were node20:

    • docker/setup-qemu-action v3 → v4
    • docker/setup-buildx-action v3 → v4
    • docker/login-action v3 → v4
    • docker/metadata-action v5 → v6
    • docker/build-push-action v5 → v7

    No with: blocks changed. The breaking changes in these majors (ESM internals, removed deprecated inputs/outputs, removed DOCKER_BUILD_NO_SUMMARY / DOCKER_BUILD_EXPORT_RETENTION_DAYS) don't touch any input this workflow uses.

  • Go version from go.mod. 1.26 was hardcoded in setup-go in both jobs and in go.mod — three places to bump. Both jobs now use go-version-file. This required moving checkout ahead of setup-go in the test job, since go-version-file is read from disk.

  • Fixed a pre-existing cache warning. The test job checks out into gopath/src/github.com/teamwork/kommentaar, so setup-go's cache looked for a dependencies file at the workspace root, found none, and logged Restore cache failed on every run (including on master today). Now pointed at the go.sum that checkout actually writes.

Verification

lint + test are covered by CI on this PR: setup-go resolves go1.26.4 from go.mod in both jobs, and the cache now saves/restores.

The build job is gated on refs/tags/v*, so CI on this PR skips it entirely — a green check here says nothing about the five Docker action bumps. It was therefore verified manually by pushing a throwaway tag (v0.0.0-node24-test) at these changes:

▶️ Build and push image — run 29328685719

That run confirms:

  • Zero node20 references anywhere in the log — all five bumped actions load and run on the node24 runtime.
  • A successful linux/amd64,linux/arm64 multi-arch manifest built and pushed to ghcr.io, so the full login-action@v4build-push-action@v7 registry path works, not just the build.

For that run only, metadata-action was temporarily pinned with flavor: latest=false so the throwaway tag could not clobber the production latest tag (the default latest=auto does apply to type=ref,event=tag, which this workflow uses). That pin was reverted and is not part of this PR. The test tag and its ghcr.io package version have since been deleted; latest still points at v0.3.3, untouched.

Notes

  • The new majors require Actions Runner v2.327.1+. ubuntu-latest satisfies this; only relevant if self-hosted runners are introduced.
  • Out of scope, but noticed: the test job still runs GO111MODULE: "off" in GOPATH mode, which is the only reason those gopath/src/... paths appear in the setup-go inputs. Worth retiring separately.

🤖 Generated with Claude Code

ripexz and others added 2 commits July 14, 2026 13:09
GitHub is deprecating the node20 Actions runtime. The five Docker actions
in the build job each declared runs.using: node20; bump them to the majors
that moved to node24. The actions in lint/test were already on node24.

Also replace the hardcoded go-version in both jobs with go-version-file, so
the Go version lives only in go.mod. This requires checkout to run before
setup-go in the test job, since go-version-file is read from disk.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The test job checks out into gopath/src/github.com/teamwork/kommentaar, so
setup-go's cache looked for a dependencies file at the workspace root, found
none, and logged "Restore cache failed" on every run. Point it at the go.sum
that checkout actually writes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29329225134

Coverage remained the same at 55.214%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 2340
Covered Lines: 1292
Line Coverage: 55.21%
Coverage Strength: 40.69 hits per line

💛 - Coveralls

@ripexz
ripexz requested review from a team and marcizhu July 14, 2026 11:40
@ripexz
ripexz merged commit b37f4b0 into master Jul 14, 2026
6 checks passed
@ripexz
ripexz deleted the workflow-updates branch July 14, 2026 11:49
@rafaeljusto

Copy link
Copy Markdown
Contributor
image

Oh, that's cool! I didn't know about it.

@ripexz

ripexz commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

Oh, that's cool! I didn't know about it.

Yeah hehe discovered recently when upgrading one of my side projects - it's a handy one, avoids having to bump numbers in multiple places 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants