ci: move off deprecated node20 actions, single-source the Go version - #116
Merged
Conversation
GitHub is deprecating the node20 Actions runtime. The five Docker actions in the build job each declared runs.using: node20; bump them to the majors that moved to node24. The actions in lint/test were already on node24. Also replace the hardcoded go-version in both jobs with go-version-file, so the Go version lives only in go.mod. This requires checkout to run before setup-go in the test job, since go-version-file is read from disk. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The test job checks out into gopath/src/github.com/teamwork/kommentaar, so setup-go's cache looked for a dependencies file at the workspace root, found none, and logged "Restore cache failed" on every run. Point it at the go.sum that checkout actually writes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Coverage Report for CI Build 29329225134Coverage remained the same at 55.214%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
marcizhu
approved these changes
Jul 14, 2026
Contributor
Member
Author
Yeah hehe discovered recently when upgrading one of my side projects - it's a handy one, avoids having to bump numbers in multiple places 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

GitHub is deprecating the
node20Actions runtime. This moves every affected action off it, and removes a version-duplication papercut while in there.Changes
node20 → node24. Checked the
runs.using:each pinned action actually declares (rather than inferring from version numbers). Thelint/testactions were already on node24; all five Docker actions in thebuildjob werenode20:docker/setup-qemu-actionv3 → v4docker/setup-buildx-actionv3 → v4docker/login-actionv3 → v4docker/metadata-actionv5 → v6docker/build-push-actionv5 → v7No
with:blocks changed. The breaking changes in these majors (ESM internals, removed deprecated inputs/outputs, removedDOCKER_BUILD_NO_SUMMARY/DOCKER_BUILD_EXPORT_RETENTION_DAYS) don't touch any input this workflow uses.Go version from
go.mod.1.26was hardcoded insetup-goin both jobs and ingo.mod— three places to bump. Both jobs now usego-version-file. This required movingcheckoutahead ofsetup-goin thetestjob, sincego-version-fileis read from disk.Fixed a pre-existing cache warning. The
testjob checks out intogopath/src/github.com/teamwork/kommentaar, so setup-go's cache looked for a dependencies file at the workspace root, found none, and loggedRestore cache failedon every run (including onmastertoday). Now pointed at thego.sumthat checkout actually writes.Verification
lint+testare covered by CI on this PR: setup-go resolves go1.26.4 fromgo.modin both jobs, and the cache now saves/restores.The
buildjob is gated onrefs/tags/v*, so CI on this PR skips it entirely — a green check here says nothing about the five Docker action bumps. It was therefore verified manually by pushing a throwaway tag (v0.0.0-node24-test) at these changes:That run confirms:
node20references anywhere in the log — all five bumped actions load and run on the node24 runtime.linux/amd64,linux/arm64multi-arch manifest built and pushed toghcr.io, so the fulllogin-action@v4→build-push-action@v7registry path works, not just the build.For that run only,
metadata-actionwas temporarily pinned withflavor: latest=falseso the throwaway tag could not clobber the productionlatesttag (the defaultlatest=autodoes apply totype=ref,event=tag, which this workflow uses). That pin was reverted and is not part of this PR. The test tag and itsghcr.iopackage version have since been deleted;lateststill points atv0.3.3, untouched.Notes
ubuntu-latestsatisfies this; only relevant if self-hosted runners are introduced.testjob still runsGO111MODULE: "off"in GOPATH mode, which is the only reason thosegopath/src/...paths appear in the setup-go inputs. Worth retiring separately.🤖 Generated with Claude Code