Feature: Share the HTTP server plumbing via pkg/mcphttp - #476
Merged
Conversation
The middleware chain, bearer auth and the health and RFC 9728 endpoints lived in cmd/mcp-http, a main package, so another server could only copy them. Auth especially must not be forked: two copies drift, and the one that drifts stops rejecting what it should. Moved to pkg/mcphttp and wired this server onto it too, which is what actually keeps the two from diverging. main.go drops 616 -> 243 lines; the server-specific bits (favicon, homepage redirect, OpenAI challenge) stay put. Also adds config.WithDefaultMCPURL. MCPURL was hardcoded to this server's host, so a second server left it advertising the wrong "resource" and pointing its 401 challenges here. The env var still wins. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The middleware chain, bearer auth and the health and RFC 9728 endpoints lived in
cmd/mcp-http, amainpackage, so another server could only copy them. Auth especially must not be forked: two copies drift, and the one that drifts stops rejecting what it should.Moved to
pkg/mcphttpand wired this server onto it too, which is what actually keeps the two from diverging.Also adds
config.WithDefaultMCPURL.MCPURLwas hardcoded to this server's host, so a second server left it advertising the wrong "resource" and pointing its 401 challenges here.Type of Change
Testing
go test -v ./...)Checklist