Feature: Add deadline and completed filters to list_milestones - #494
Merged
Conversation
Adds due_after, due_before and show_completed, so a schedule check can filter in the request instead of paging every milestone and filtering the reply. show_completed defaults to true, unlike list_tasks: milestones come back in every state, so only an explicit false narrows the list. Needs SDK v1.26.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
due_after,due_beforeandshow_completed, so a schedule check can filter in the request instead of paging through every milestone and filtering the reply.show_completeddefaults to true, unlikelist_tasks: milestones come back in every state, so only an explicit false narrows the list. Needs SDK v1.26.0.Type of Change
Testing
go test -v ./...)Checklist