Fix: Tell callers to omit notify and keep the default recipients - #514
Merged
Conversation
The notify parameter is a single value on the wire, so a supplied one replaces the default recipients instead of widening them: asked to comment and let one person know, a client sets notify to that person alone and every follower the default would have notified is dropped. Nothing reveals it - the response carries no recipient list, and no read path returns a comment's followers - so the call looks like it worked. The description advertised the accepted shapes and nothing about the cost of using one, which reads as an invitation to fill the parameter in. It now opens by saying to omit it unless the caller named who to notify, and names the default it would be replacing: every follower of the related entity for comments, all project members for messages, replies and links. Omitting the parameter is not the same as omitting the field, which is what makes the advice safe to give: the handlers substitute their own default, where the endpoints left to themselves notify nobody. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rafaeljusto
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trap
notifyis a single value on the wire —true,"ALL", or a comma-separated ID list. There is no additive shape, so a supplied value replaces the default recipients rather than widening them. Asked to comment and let one person know, a client setsnotifyto that person alone and every follower the default would have notified is dropped.Nothing reveals it. The response carries no recipient list,
projects.Commenthas no follower field, and no read path returns one — so the call succeeds identically either way and the mistake is never learnt.The description advertised the accepted shapes and said nothing about the cost of using one, which reads as an invitation to fill the parameter in.
The change
helpers.NotifySchemanow opens by telling the caller to omit it, and names the default it would be replacing:The wording follows the parameter's existing split: every follower of the related entity for comments, all project members for messages, replies and links — all 8 call sites, since the same trap applies to each.
Omitting the parameter is not the same as omitting the field, which is what makes the advice safe to give: the handlers substitute their own default (
1f7c708), where the endpoints left to themselves notify nobody.Notes
TestNotifySchemapins both branches — the advice, the default it names, and that every shapeparseNotifycoerces is still advertised.go run ./cmd/mcp-tokens -base=main), spread over 8 tools.🤖 Generated with Claude Code