Rust Iron framework #1101

torhve · Oct 17, 2014

No description provided.

msmith-techempower · Oct 17, 2014

msmith-techempower reviewed Oct 17, 2014

View changes

msmith-techempower · Oct 17, 2014

toolset/setup/linux/frameworks/rust.sh

+RETCODE=$(fw_exists rust.installed)
+[ ! "$RETCODE" == 0 ] || { return 0; }
+
+curl -s https://static.rust-lang.org/rustup.sh | sudo sh


Is there any chance this could be changed to a permalink with a version?

hamiltont · Oct 17, 2014

hamiltont reviewed Oct 17, 2014

View changes

hamiltont · Oct 17, 2014

toolset/setup/linux/frameworks/rust.sh

+[ ! "$RETCODE" == 0 ] || { return 0; }
+
+curl -s https://static.rust-lang.org/rustup.sh | sudo sh
+


Could you add the equivalent of rust --version here, so log output will have the version

@torhve

@torhve Looks like it's still failing to complile: https://travis-ci.org/TechEmpower/FrameworkBenchmarks/jobs/38420515

CalledProcessError: Command 'cargo build --release' returned non-zero exit status 101

msmith-techempower · Oct 22, 2014

@torhve Looks like it's still failing to complile: https://travis-ci.org/TechEmpower/FrameworkBenchmarks/jobs/38420515

CalledProcessError: Command 'cargo build --release' returned non-zero exit status 101

Looks like it tests OK now, but the build still fails.
It looks like it might be the verify is failing or setup script? Output from the actualy web testing looks OK.

torhve · Oct 26, 2014

Looks like it tests OK now, but the build still fails.
It looks like it might be the verify is failing or setup script? Output from the actualy web testing looks OK.

@torhve

@torhve I think this is our toolset having some growing pains - we will try and get this fixed up soon.

msmith-techempower · Oct 27, 2014

@torhve I think this is our toolset having some growing pains - we will try and get this fixed up soon.

The Rust work all LGTM. My vote is to merge this PR, but create an issue
indicating that something is failing with our test framework here. It
shouldn't say everything passes and then return 1, that's a bug somewhere

hamiltont · Oct 27, 2014

The Rust work all LGTM. My vote is to merge this PR, but create an issue
indicating that something is failing with our test framework here. It
shouldn't say everything passes and then return 1, that's a bug somewhere

@hamiltont

@hamiltont Are you saying that you tested this with your travis instance and it worked?

msmith-techempower · Oct 28, 2014

@hamiltont Are you saying that you tested this with your travis instance and it worked?

@hamiltont

I am saying that the detailed output logs for the last travis build on this
pull request indicate that rust passed all verification tests successfully.
The travis build should have been green, but it looks like there is a bug
causing run tests to return exit code 1 when it should have returning exit
code 0
On Oct 28, 2014 2:37 PM, "Mike Smith" notifications@github.com wrote:

@hamiltont https://github.com/hamiltont Are you saying that you tested
this with your travis instance and it worked?

—
Reply to this email directly or view it on GitHub
#1101 (comment)
.

hamiltont · Oct 28, 2014

I am saying that the detailed output logs for the last travis build on this
pull request indicate that rust passed all verification tests successfully.
The travis build should have been green, but it looks like there is a bug
causing run tests to return exit code 1 when it should have returning exit
code 0
On Oct 28, 2014 2:37 PM, "Mike Smith" notifications@github.com wrote:

@hamiltont https://github.com/hamiltont Are you saying that you tested
this with your travis instance and it worked?

—
Reply to this email directly or view it on GitHub
#1101 (comment)
.

@hamiltont

Although I did not look for an error message about the port not being
released by stop . Perhaps that is what is happening here , someone needs
to read the detailed log carefully
On Oct 28, 2014 2:49 PM, "Hamilton Turner" hamiltont@gmail.com wrote:

I am saying that the detailed output logs for the last travis build on
this pull request indicate that rust passed all verification tests
successfully. The travis build should have been green, but it looks like
there is a bug causing run tests to return exit code 1 when it should have
returning exit code 0
On Oct 28, 2014 2:37 PM, "Mike Smith" notifications@github.com wrote:

@hamiltont https://github.com/hamiltont Are you saying that you tested
this with your travis instance and it worked?

—
Reply to this email directly or view it on GitHub
#1101 (comment)
.

hamiltont · Oct 28, 2014

Although I did not look for an error message about the port not being
released by stop . Perhaps that is what is happening here , someone needs
to read the detailed log carefully
On Oct 28, 2014 2:49 PM, "Hamilton Turner" hamiltont@gmail.com wrote:

I am saying that the detailed output logs for the last travis build on
this pull request indicate that rust passed all verification tests
successfully. The travis build should have been green, but it looks like
there is a bug causing run tests to return exit code 1 when it should have
returning exit code 0
On Oct 28, 2014 2:37 PM, "Mike Smith" notifications@github.com wrote:

@hamiltont https://github.com/hamiltont Are you saying that you tested
this with your travis instance and it worked?

—
Reply to this email directly or view it on GitHub
#1101 (comment)
.

I see the exact error message and understand it. Basically, this was pulled before your reworked of our __forciblyEndPortBoundProcesses to have tuple out/err from the communicates. Essentially, we were trying to write to an instance of err that didn't exist because it overwrote the original.

Rant: this is why I hate python sometimes - why can I redeclare variables? Oh, because declaration and assignment are the same. /rant

I agree that this looks like Rust isn't probably stoping; we would have more useful information after a rebase and a rerun after we merge #1145

msmith-techempower · Oct 28, 2014

I see the exact error message and understand it. Basically, this was pulled before your reworked of our __forciblyEndPortBoundProcesses to have tuple out/err from the communicates. Essentially, we were trying to write to an instance of err that didn't exist because it overwrote the original.

Rant: this is why I hate python sometimes - why can I redeclare variables? Oh, because declaration and assignment are the same. /rant

I agree that this looks like Rust isn't probably stoping; we would have more useful information after a rebase and a rerun after we merge #1145

@torhve

@torhve I pulled your latest and there is still an error:

INFO:root:Start exception:
    Traceback (most recent call last):
      File "/home/techempower/FrameworkBenchmarks/toolset/benchmark/framework_test.py", line 153, in start
        retcode = self.setup_module.start(self, out, err)
      File "/home/techempower/FrameworkBenchmarks/frameworks/Rust/Iron/setup.py", line 8, in start
        subprocess.check_call("cargo build --release", shell=True, cwd="Iron", stderr=errfile, stdout=logfile)
      File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
        raise CalledProcessError(retcode, cmd)
    CalledProcessError: Command 'cargo build --release' returned non-zero exit status 101

msmith-techempower · Oct 31, 2014

@torhve I pulled your latest and there is still an error:

INFO:root:Start exception:
    Traceback (most recent call last):
      File "/home/techempower/FrameworkBenchmarks/toolset/benchmark/framework_test.py", line 153, in start
        retcode = self.setup_module.start(self, out, err)
      File "/home/techempower/FrameworkBenchmarks/frameworks/Rust/Iron/setup.py", line 8, in start
        subprocess.check_call("cargo build --release", shell=True, cwd="Iron", stderr=errfile, stdout=logfile)
      File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
        raise CalledProcessError(retcode, cmd)
    CalledProcessError: Command 'cargo build --release' returned non-zero exit status 101

Ugh, the bleeding edge has cut you again:

techempower@tfbapp3:~/FrameworkBenchmarks/frameworks/Rust/Iron$ cargo build --release
   Compiling mysql v0.0.0 (https://github.com/blackbeam/rust-mysql-simple#7934b0ee)
   Compiling http v0.1.0-pre (https://github.com/chris-morgan/rust-http.git#c8aef7e0)
src/value.rs:6:16: 6:27 error: unresolved import `std::i64::parse_bytes`. There is no `parse_bytes` in `std::i64`
src/value.rs:6 use std::i64::{parse_bytes};
                              ^~~~~~~~~~~
error: aborting due to previous error
Build failed, waiting for other jobs to finish...
Could not compile `mysql`.

To learn more, run the command again with --verbose.

Additionally, you will need to rebase master into your branch to get it to work.

msmith-techempower · Nov 5, 2014

Ugh, the bleeding edge has cut you again:

techempower@tfbapp3:~/FrameworkBenchmarks/frameworks/Rust/Iron$ cargo build --release
   Compiling mysql v0.0.0 (https://github.com/blackbeam/rust-mysql-simple#7934b0ee)
   Compiling http v0.1.0-pre (https://github.com/chris-morgan/rust-http.git#c8aef7e0)
src/value.rs:6:16: 6:27 error: unresolved import `std::i64::parse_bytes`. There is no `parse_bytes` in `std::i64`
src/value.rs:6 use std::i64::{parse_bytes};
                              ^~~~~~~~~~~
error: aborting due to previous error
Build failed, waiting for other jobs to finish...
Could not compile `mysql`.

To learn more, run the command again with --verbose.

Additionally, you will need to rebase master into your branch to get it to work.

I suggest that you clamp down the version being used. Maybe just use v0.12.0 for the time being?

https://static.rust-lang.org/dist/rust-0.12.0-x86_64-unknown-linux-gnu.tar.gz

msmith-techempower · Nov 10, 2014

I suggest that you clamp down the version being used. Maybe just use v0.12.0 for the time being?

https://static.rust-lang.org/dist/rust-0.12.0-x86_64-unknown-linux-gnu.tar.gz

There are still some warnings, and the process does not exit successfully, but we are able to start/run/stop... so I'm considering merging this.

My biggest concern is that if I merge this, the nightly build will break it two days from now.

msmith-techempower · Nov 11, 2014

There are still some warnings, and the process does not exit successfully, but we are able to start/run/stop... so I'm considering merging this.

My biggest concern is that if I merge this, the nightly build will break it two days from now.

any updates on merging this?

Vikaton · Feb 8, 2015

any updates on merging this?

@Ap0ph1s

@Ap0ph1s I think the main concern is this line curl -s https://static.rust-lang.org/rustup.sh | sudo sh, becuase it was regularly returning a different version of rust and breaking this PR. I think @torhve updated this multiple times because Rust was moving so quickly.

There's not much value in merging something that's only stable for a week, so IIRC the consensus is that this needs to be linked to one version, but it's unclear which version. If you're interested in seeing Rust results ASAP, feel free to pull this branch into your own repo, fix it to a single worthy version, and send in an updated PR

hamiltont · Feb 8, 2015

@Ap0ph1s I think the main concern is this line curl -s https://static.rust-lang.org/rustup.sh | sudo sh, becuase it was regularly returning a different version of rust and breaking this PR. I think @torhve updated this multiple times because Rust was moving so quickly.

There's not much value in merging something that's only stable for a week, so IIRC the consensus is that this needs to be linked to one version, but it's unclear which version. If you're interested in seeing Rust results ASAP, feel free to pull this branch into your own repo, fix it to a single worthy version, and send in an updated PR

I see this timeline, perhaps this could be fixed to the beta when it's out?

Rust 1.0.0-alpha – Friday, Jan 9, 2015
Rust 1.0.0-beta1 – Week of Feb 16, 2015
Rust 1.0.0 – One or more six-week cycles later

hamiltont · Feb 8, 2015

I see this timeline, perhaps this could be fixed to the beta when it's out?

Rust 1.0.0-alpha – Friday, Jan 9, 2015
Rust 1.0.0-beta1 – Week of Feb 16, 2015
Rust 1.0.0 – One or more six-week cycles later

Oh, I also see that the alpha candidate is supposedly feature complete, so it is not too unreasonable to fix this to the alpha if the beta is taking too long as the upgrade should be painless

hamiltont · Feb 8, 2015

Oh, I also see that the alpha candidate is supposedly feature complete, so it is not too unreasonable to fix this to the alpha if the beta is taking too long as the upgrade should be painless

Rust is improving every day, whether performance or features, or even both, so I think It can wait until beta1, or the actual 1.0, every version that comes out is more worthy than the last.

Vikaton · Feb 8, 2015

Rust is improving every day, whether performance or features, or even both, so I think It can wait until beta1, or the actual 1.0, every version that comes out is more worthy than the last.

Rust 1.0 has now been released. I guess it would be worth putting some more work into this.

fbernier · May 21, 2015

Rust 1.0 has now been released. I guess it would be worth putting some more work into this.

oh, i missed this PR, and wrote up #1636 . Time to compare!

steveklabnik · May 31, 2015

oh, i missed this PR, and wrote up #1636 . Time to compare!

Closing in favor of #1638

msmith-techempower · Jun 5, 2015

Closing in favor of #1638

Add Rust Iron

84d6036

torhve added some commits Oct 17, 2014

Add Rust to travis

0e545a5

Print rust version

758ce24

Fix the path

b63a812

Fix cargo building by removing ssl feature from mysql

69ce71e

torhve added some commits Oct 24, 2014

switch back to upstream htmlescape

2c4b403

back to the fork

e7e39c3

Freeze rust dependencies versions

be498f7

torhve added some commits Nov 4, 2014

Update versions to make it compile with nightly

796cd94

search for correct process

c94a64d

safeguards in check

82edded

torhve added some commits Nov 6, 2014

update to work with rust nightly again

da08009

Update versions to work with nightly

923bf16

Update Iron to use the new response modifiers

f48c4bb

msmith-techempower added PR: Please Update and removed PR: Please Update labels Jan 22, 2015

msmith-techempower added the PR: Please Update label Jan 22, 2015

torhve referenced this pull request May 31, 2015
Merged
Add Rust #1636

msmith-techempower closed this Jun 5, 2015

msmith-techempower removed the PR: Please Update label Jun 5, 2015

TechEmpower/FrameworkBenchmarks

Join GitHub today

Rust Iron framework #1101

Conversation

torhve commented Oct 17, 2014

msmith-techempower reviewed Oct 17, 2014 View changes

This comment has been minimized.

hamiltont reviewed Oct 17, 2014 View changes

This comment has been minimized.

torhve added some commits Oct 17, 2014

This comment has been minimized.

msmith-techempower commented Oct 22, 2014

torhve added some commits Oct 24, 2014

This comment has been minimized.

torhve commented Oct 26, 2014

This comment has been minimized.

msmith-techempower commented Oct 27, 2014

This comment has been minimized.

hamiltont commented Oct 27, 2014

This comment has been minimized.

msmith-techempower commented Oct 28, 2014

This comment has been minimized.

hamiltont commented Oct 28, 2014

This comment has been minimized.

hamiltont commented Oct 28, 2014

This comment has been minimized.

msmith-techempower commented Oct 28, 2014

This comment has been minimized.

msmith-techempower commented Oct 31, 2014

torhve added some commits Nov 4, 2014

This comment has been minimized.

msmith-techempower commented Nov 5, 2014

torhve added some commits Nov 6, 2014

This comment has been minimized.

msmith-techempower commented Nov 10, 2014

This comment has been minimized.

msmith-techempower commented Nov 11, 2014

msmith-techempower added PR: Please Update and removed PR: Please Update labels Jan 22, 2015

msmith-techempower added the PR: Please Update label Jan 22, 2015

This comment has been minimized.

Vikaton commented Feb 8, 2015

This comment has been minimized.

hamiltont commented Feb 8, 2015

This comment has been minimized.

hamiltont commented Feb 8, 2015

This comment has been minimized.

hamiltont commented Feb 8, 2015

This comment has been minimized.

Vikaton commented Feb 8, 2015

This comment has been minimized.

fbernier commented May 21, 2015

This comment has been minimized.

steveklabnik commented May 31, 2015

torhve referenced this pull request May 31, 2015

This comment has been minimized.

msmith-techempower commented Jun 5, 2015

msmith-techempower closed this Jun 5, 2015

msmith-techempower removed the PR: Please Update label Jun 5, 2015

msmith-techempower reviewed Oct 17, 2014

View changes

hamiltont reviewed Oct 17, 2014

View changes