Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Add Rust#1636

Merged
msmith-techempower merged 8 commits intoTechEmpower:masterfrom
steveklabnik:rust
Jun 10, 2015
Merged

Add Rust#1636
msmith-techempower merged 8 commits intoTechEmpower:masterfrom
steveklabnik:rust

Conversation

@steveklabnik
Copy link
Copy Markdown
Contributor

Hey there! Now that Rust is 1.0, I figured adding some Rust stuff to the benchmarks would be cool :)

I haven't gotten it all working, but, in the interest of 'release early, release often', I wanted to check that my setup is vaguely on track. VirtualBox isn't working on my computer right now, so I don't have any error messages or anything, but was interested in early feedback anyway.

Thoughts?

@torhve
Copy link
Copy Markdown
Contributor

torhve commented May 31, 2015

There's an old PR here that might be revived: #1101

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cargo would not be on your path at this point - try pointing to it directly $IROOT/rust/bin/cargo or whatever the sandboxed path will be.

@steveklabnik
Copy link
Copy Markdown
Contributor Author

Status update: I haven't gotten VirtualBox to work, but will be updating this PR tomorrow.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove set here, perhaps you want local.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i'm bad at bash, sigh

@steveklabnik
Copy link
Copy Markdown
Contributor Author

So, I still cannot get virtualbox to work on my computer. But, I've added an implementation of the plaintext test.

Can anyone tell if this actually runs or not yet? :/

At least once this setup is done, it will work for all future Rust projects...

@steveklabnik
Copy link
Copy Markdown
Contributor Author

/cc @seanmonstar, as he's the maintainer of hyper

@steveklabnik
Copy link
Copy Markdown
Contributor Author

Oh, I need to do the sed properly to set the port...

@steveklabnik
Copy link
Copy Markdown
Contributor Author

... in the future, anyway. i just left a note for now, since I didn't implement the database test

@steveklabnik steveklabnik changed the title WIP: Add Rust Add Rust Jun 4, 2015
@steveklabnik
Copy link
Copy Markdown
Contributor Author

@msmith-techempower i think this is ready for a re-review

@msmith-techempower
Copy link
Copy Markdown
Member

Currently being reviewed by Travis-CI.

@steveklabnik
Copy link
Copy Markdown
Contributor Author

Ahh interesting, so I saw the failures in other builds, but didn't realize that they were builds per language. That's super neat. I'll pay close attention to the specific build, thank you! Still getting used to navigating this project. :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this Ok is dangling

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would get a type error when it's not included

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.... but now I don't. cool. :)

@steveklabnik
Copy link
Copy Markdown
Contributor Author

@Geal and I paired, and this should be working now, so let's just wait for travis! 🎊

@msmith-techempower
Copy link
Copy Markdown
Member

You should probably rebase off of master and take a look at #1638 to get Hyper working; it's a pretty good starting point.

@steveklabnik
Copy link
Copy Markdown
Contributor Author

Will do in the next day or two :)

@steveklabnik
Copy link
Copy Markdown
Contributor Author

rebased and updated. #1638 had a lot of goodies :)

@msmith-techempower
Copy link
Copy Markdown
Member

Hmm, it claims that cargo could not be found, but an audit of your install and setup shows that you are following the correct order. I'll try and pull this to test manually and let you know.

@steveklabnik
Copy link
Copy Markdown
Contributor Author

Yeah, strange. I followed the other PR here, so if it works, this should work.

@msmith-techempower
Copy link
Copy Markdown
Member

I have no idea why Travis doesn't like this - I tested it locally and it seems to work.

@msmith-techempower
Copy link
Copy Markdown
Member

Oh I see, there was an issue handshaking (SSL) when trying to get the binary. Oh well, this is working locally; LGTM!

msmith-techempower added a commit that referenced this pull request Jun 10, 2015
@msmith-techempower msmith-techempower merged commit 1a23d85 into TechEmpower:master Jun 10, 2015
@steveklabnik
Copy link
Copy Markdown
Contributor Author

🎊

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants