Conversation
|
There's an old PR here that might be revived: #1101 |
frameworks/Rust/hyper/setup.sh
Outdated
There was a problem hiding this comment.
Cargo would not be on your path at this point - try pointing to it directly $IROOT/rust/bin/cargo or whatever the sandboxed path will be.
|
Status update: I haven't gotten VirtualBox to work, but will be updating this PR tomorrow. |
frameworks/Rust/hyper/setup.sh
Outdated
There was a problem hiding this comment.
Remove set here, perhaps you want local.
There was a problem hiding this comment.
yeah i'm bad at bash, sigh
|
So, I still cannot get virtualbox to work on my computer. But, I've added an implementation of the Can anyone tell if this actually runs or not yet? :/ At least once this setup is done, it will work for all future Rust projects... |
|
/cc @seanmonstar, as he's the maintainer of hyper |
|
Oh, I need to do the |
|
... in the future, anyway. i just left a note for now, since I didn't implement the database test |
|
@msmith-techempower i think this is ready for a re-review |
|
Currently being reviewed by Travis-CI. |
|
Ahh interesting, so I saw the failures in other builds, but didn't realize that they were builds per language. That's super neat. I'll pay close attention to the specific build, thank you! Still getting used to navigating this project. :) |
frameworks/Rust/hyper/src/main.rs
Outdated
There was a problem hiding this comment.
I would get a type error when it's not included
There was a problem hiding this comment.
.... but now I don't. cool. :)
|
@Geal and I paired, and this should be working now, so let's just wait for travis! 🎊 |
|
You should probably rebase off of master and take a look at #1638 to get Hyper working; it's a pretty good starting point. |
|
Will do in the next day or two :) |
|
rebased and updated. #1638 had a lot of goodies :) |
|
Hmm, it claims that |
|
Yeah, strange. I followed the other PR here, so if it works, this should work. |
|
I have no idea why Travis doesn't like this - I tested it locally and it seems to work. |
|
Oh I see, there was an issue handshaking (SSL) when trying to get the binary. Oh well, this is working locally; LGTM! |
|
🎊 |
Hey there! Now that Rust is 1.0, I figured adding some Rust stuff to the benchmarks would be cool :)
I haven't gotten it all working, but, in the interest of 'release early, release often', I wanted to check that my setup is vaguely on track. VirtualBox isn't working on my computer right now, so I don't have any error messages or anything, but was interested in early feedback anyway.
Thoughts?