This repository was archived by the owner on Mar 24, 2026. It is now read-only.
Finch 0.10.0#1933
Merged
ssmith-techempower merged 4 commits intoTechEmpower:masterfrom Mar 8, 2016
mfirry:master
Merged
Conversation
| object WebServer extends App { | ||
|
|
||
| import io.finch.circe._ | ||
| val json = get("json") { |
Contributor
There was a problem hiding this comment.
Can we put type here Endpoint[io.circe.Json] and return Json.obj("message" -> Json.string("Hello, World!")) directly?
Contributor
|
Thanks @mfirry for taking care of this! |
Contributor
Author
|
Ideally one should disable gzip and add |
Contributor
|
You can disable compression by |
Contributor
|
👍 Thanks @mfirry! Looks great! |
| Await.ready( | ||
| Httpx.serve(":9000", api) | ||
| Await.ready(Http.server | ||
| .withCompressionLevel(0) |
Contributor
There was a problem hiding this comment.
Sorry to bother again, but can you also disable stats receiver and tracer on a server instance? (in a same way as per #1941).
.withStatsReceiver(NullStatsReceiver)
.withTracer(NullTracer)
Contributor
|
Looks good to me, merging in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finch bumped to 0.10.0.