This repository was archived by the owner on Mar 24, 2026. It is now read-only.
Update Finagle benchmark#1941
Merged
ssmith-techempower merged 1 commit intoTechEmpower:masterfrom Mar 8, 2016
Merged
Conversation
Merged
vkostyukov
force-pushed
the
upgrate-finagle
branch
2 times, most recently
from
564c9eb to
78da111
Compare
Contributor
|
@vkostyukov Aren't you supposed to serialize the json at each hit? You are serializing once and outputing it like static binary data. Your json test looks like the plaintext one.
|
vkostyukov
force-pushed
the
upgrate-finagle
branch
from
78da111 to
0d2692f
Compare
Contributor
Author
|
Oh you're right, @Rydgel! I guess I just misunderstood that while porting the implementation from a different benchmark. Fixed it now. Thanks! |
Contributor
|
Lookin' good now! |
Contributor
|
Looks good to me, merging in. |
ssmith-techempower
added a commit
that referenced
this pull request
Mar 8, 2016
Update Finagle benchmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup and updated Finagle benchmark so it now includes JSON serialization (
/json) and plain text endpoints (/plaintext).