Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Finagle benchmark #1941
Conversation
vkostyukov
changed the title from
Update Finagle benchamrk
to
Update Finagle benchmark
Feb 25, 2016
zloster
referenced this pull request
Feb 25, 2016
Closed
Java tests - java.util.Random usage may lead to non-optimal performance in heavy concurency conditions #1152
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Rydgel
Mar 7, 2016
Contributor
@vkostyukov Aren't you supposed to serialize the json at each hit? You are serializing once and outputing it like static binary data. Your json test looks like the plaintext one.
- For each request, an object mapping the key message to Hello, World! must be instantiated.
- […]
- A JSON serializer must be used to convert the object to JSON.
|
@vkostyukov Aren't you supposed to serialize the json at each hit? You are serializing once and outputing it like static binary data. Your json test looks like the plaintext one.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
vkostyukov
Mar 7, 2016
Contributor
Oh you're right, @Rydgel! I guess I just misunderstood that while porting the implementation from a different benchmark. Fixed it now. Thanks!
|
Oh you're right, @Rydgel! I guess I just misunderstood that while porting the implementation from a different benchmark. Fixed it now. Thanks! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Lookin' good now! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Looks good to me, merging in. |
vkostyukov commentedFeb 25, 2016
Cleanup and updated Finagle benchmark so it now includes JSON serialization (
/json) and plain text endpoints (/plaintext).