New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hexagon #2421

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@nbrady-techempower
Member

nbrady-techempower commented Dec 23, 2016

Fixed the malformed benchmark_config file so that hexagon isn't being reported as not having a default test.

Tied down gradle.properties to a specific commit. Recent pushes to master are breaking tests.

@jaguililla The resin tests are no longer working. Would you be able to explore?

@knewmanTE

This comment has been minimized.

Show comment
Hide comment
@knewmanTE

knewmanTE Dec 23, 2016

Contributor

@nbrady-techempower are any Resin tests working since the database setup changes?

Contributor

knewmanTE commented Dec 23, 2016

@nbrady-techempower are any Resin tests working since the database setup changes?

@nbrady-techempower

This comment has been minimized.

Show comment
Hide comment
@nbrady-techempower

nbrady-techempower Dec 23, 2016

Member

@knewmanTE Yeah, tapestry and wicket are both using resin and they're passing.

Member

nbrady-techempower commented Dec 23, 2016

@knewmanTE Yeah, tapestry and wicket are both using resin and they're passing.

@knewmanTE

This comment has been minimized.

Show comment
Hide comment
@knewmanTE

knewmanTE Dec 23, 2016

Contributor

While you're updating the Hexagon metadata, could you change the webserver on the Resin test from "None" to " Resin" ?

Contributor

knewmanTE commented Dec 23, 2016

While you're updating the Hexagon metadata, could you change the webserver on the Resin test from "None" to " Resin" ?

@jaguililla

This comment has been minimized.

Show comment
Hide comment
@jaguililla

jaguililla Dec 24, 2016

Contributor

I didn't see the config error, neither the problem with the Gradle scripts. Thanks for the update!

I'll check the error with Resin. It is working on my machine, so I guess there should be something with my setup_resin.sh script.

Anyway, that would be next week. I wish you a merry christmas, enjoy it with your family and friends :)

Contributor

jaguililla commented Dec 24, 2016

I didn't see the config error, neither the problem with the Gradle scripts. Thanks for the update!

I'll check the error with Resin. It is working on my machine, so I guess there should be something with my setup_resin.sh script.

Anyway, that would be next week. I wish you a merry christmas, enjoy it with your family and friends :)

@nbrady-techempower

This comment has been minimized.

Show comment
Hide comment
@nbrady-techempower

nbrady-techempower Dec 27, 2016

Member

Closing this in favor of the framework owner's pr

Member

nbrady-techempower commented Dec 27, 2016

Closing this in favor of the framework owner's pr

LadyMozzarella added a commit that referenced this pull request Dec 27, 2016

Merge pull request #2422 from jaguililla/master
Apply fixes for Resing test as stated in #2421

@nbrady-techempower nbrady-techempower deleted the nbrady-techempower:hexagon branch Dec 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment