Netty: IDE warnings cleanup, removed unnecessary inheritance, simplified code.

[doom369]

Removed

b.childOption(ChannelOption.ALLOCATOR, new PooledByteBufAllocator(true));

as netty now uses PooledByteBufAllocator by default.

HelloServerHandler now Inherits ChannelInboundHandlerAdapter instead of SimpleChannelInboundHandler. As ChannelInboundHandlerAdapter does a bit less operations and allocated less for HelloServerHandler.

writeResponse divided into 2 methods for plain response and json response.

[mention-bot]

Thanks @doom369 for contributing to The Framework Benchmarks! @lneves and @normanmaurer, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message [ci skip] and your github name added to the userBlacklist array in the .mention-bot file.

[lneves]

After this change "wrk" starts giving lots of connection errors, curl also complains with the warning: "Excess found in a non pipelined read".
Don't have time to debug it now. @doom369 can you confirm this behaviour?

[doom369]

@lneves interesting. Let me check.

[lneves]

here you go:

curl -v http://127.0.0.1:8080/json
*   Trying 127.0.0.1...
* Connected to 127.0.0.1 (127.0.0.1) port 8080 (#0)
> GET /json HTTP/1.1
> Host: 127.0.0.1:8080
> User-Agent: curl/7.47.0
> Accept: */*
> 
< HTTP/1.1 200 OK
< content-type: application/json
< server: Netty
< date: Ter, 30 mai 2017 18:15:04 WEST
< content-length: 27
< 
* Excess found in a non pipelined read: excess = 26, size = 27, maxdownload = 27, bytecount = 0
* Connection #0 to host 127.0.0.1 left intact

[doom369]

@lneves yeah, thanks. My bad. Fixed.

[lneves]

LGTM!