This repository was archived by the owner on Mar 24, 2026. It is now read-only.
Add IncludeOS Mana framework (C++ unikernel)#2936
Merged
NateBrady23 merged 2 commits intoTechEmpower:masterfrom Nov 6, 2017
Merged
Add IncludeOS Mana framework (C++ unikernel)#2936NateBrady23 merged 2 commits intoTechEmpower:masterfrom
NateBrady23 merged 2 commits intoTechEmpower:masterfrom
Conversation
… endings except powershell scripts
* Use Docker to build and run IncludeOS-Mana * Freeze IncludeOS to dev@807b424, v0.11.0-bundle fails on build
This was referenced Aug 15, 2017
Member
|
@ciarancourtney Thanks for both of your recent submissions! Resources are a little tight for the next week or so but we should be able to review these shortly. |
msmith-techempower
approved these changes
Nov 6, 2017
Member
msmith-techempower
left a comment
msmith-techempower
left a comment
There was a problem hiding this comment.
One tiny nit, but looks good to me; LGTM!
| "approach": "Stripped", | ||
| "classification": "Platform", | ||
| "database": "None", | ||
| "framework": "Mana", |
Member
There was a problem hiding this comment.
This should be None if the classification is Platform (or if there is a different framework used, list that here)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I think this is the first unikernel based framework to be added, in its current state it will not generate results as expected, the request count will be zero, as the framework becomes unresponsive soon after the benchmark begins, I'm still working on getting this resolved.
Also I think this is the first test to use docker to execute the framework (the native framework of IncludeOS is bare-metal or KVM hypervisor) as it requires Ubuntu 16.04 to build. The built unikernel is then executed on Ubuntu using QEMU, which is not a typical production scenario at all, the poor results probably reflect that. To fix this later would require booting the built unikernel on KVM (GCE for example)
Also the Travis build will fail at the "Building IncludeOS Mana server" step (CMake file does not exist error), but not locally on vagrant, couldn't figure this out, input welcome.
Feedback welcome!
Thanks