This repository was archived by the owner on Mar 24, 2026. It is now read-only.
Add MirageOS HTTP server (OCaml unikernel)#2938
Closed
ciarancourtney wants to merge 2 commits intoTechEmpower:masterfrom
Closed
Add MirageOS HTTP server (OCaml unikernel)#2938ciarancourtney wants to merge 2 commits intoTechEmpower:masterfrom
ciarancourtney wants to merge 2 commits intoTechEmpower:masterfrom
Conversation
* Remove unnecessary --no-debug flag * Removes production flag
15840c0 to
d829af3
Compare
* Use Conduit HTTP server booted as virtio via qemu instead of unix mode
d829af3 to
5be2b0d
Compare
msmith-techempower
suggested changes
Nov 8, 2017
|
|
||
| # FIXME | ||
| # * Need to change TFB-Server to 10.0.0.2 in /etc/hosts, hostfwd doesn't seem to work with qemu tap network config | ||
| # * No newline at end of file |
Member
There was a problem hiding this comment.
This entire file needs to be redone. OCaml should be installed in a similar fashion to how other languages are; see DLang.
Also, we would prefer an installation which does not rely on apt-get if possible
| ### TODO | ||
|
|
||
| * Under load the server will crash with a Unix.EINVAL or similar exception, this open issue is | ||
| detailed [here](https://github.com/mirage/ocaml-cohttp/issues/503) No newline at end of file |
Member
There was a problem hiding this comment.
This is likely to be a problem in actual benchmarking efforts.
| qemu-system-x86_64 -daemonize -cpu Westmere -m 128 -nodefaults -no-acpi -display none -device virtio-net,netdev=n0 -netdev tap,id=n0,ifname=tap0,script=no,downscript=no -device isa-debug-exit -kernel conduit_server.virtio | ||
|
|
||
| # FIXME | ||
| # * Need to change TFB-Server to 10.0.0.2 in /etc/hosts, hostfwd doesn't seem to work with qemu tap network config |
Member
There was a problem hiding this comment.
Using qemu may introduce latency for every lookup of TFB-Server, but I am unfamiliar.
Member
|
@ciarancourtney Going to close this for now since it's getting stale. If you're able to address any of the reviews, or have any questions please feel free to re-open and continue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Carrying on from #2936, this PR adds another popular unikernel implementation called MirageOS
Tested on my own Travis and the plaintext test passes with results.
There are two workarounds applied to the code that prevent memory leaks and max open fd exceptions respectively, hopefully these are resolved in subsequent releases.
Feedback welcome!
Thanks