This repository was archived by the owner on Mar 24, 2026. It is now read-only.
crystal add --no-debug to release build for llvm-3.8#2966
Closed
drujensen wants to merge 1 commit intoTechEmpower:masterfrom
drujensen:dj/fix-crystal-builds
Closed
crystal add --no-debug to release build for llvm-3.8#2966drujensen wants to merge 1 commit intoTechEmpower:masterfrom drujensen:dj/fix-crystal-builds
drujensen wants to merge 1 commit intoTechEmpower:masterfrom
drujensen:dj/fix-crystal-builds
Conversation
|
Thanks @drujensen for contributing to The Framework Benchmarks! @faustinoaq, @sdogruyol, @Jesterovskiy, @will, @nbrady-techempower, @msmith-techempower, @foliot and @zane-techempower, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message |
drujensen
changed the title
Contributor
|
Why is this not part of #2965? |
Contributor
Author
|
@RX14 yeah, i guess its dependent. I will move it over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sdogruyol @RX14 This add the
--no-debugflag to crystal-raw, kemal, and amber for crystal 0.23.1 and llvm-3.8.