Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

update crystal to latest version 0.23.1#2965

Merged
NateBrady23 merged 4 commits intoTechEmpower:masterfrom
drujensen:dj/update-crystal-to-0.23.1
Sep 11, 2017
Merged

update crystal to latest version 0.23.1#2965
NateBrady23 merged 4 commits intoTechEmpower:masterfrom
drujensen:dj/update-crystal-to-0.23.1

Conversation

@drujensen
Copy link
Copy Markdown
Contributor

This updates crystal to the latest version 0.23.1

@mention-bot
Copy link
Copy Markdown

Thanks @drujensen for contributing to The Framework Benchmarks! @RX14, @msmith-techempower, @will, @kbrock, @jhass, @nbrady-techempower and @zane-techempower, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message [ci skip] and your github name added to the userBlacklist array in the .mention-bot file.

@NateBrady23
Copy link
Copy Markdown
Member

@drujensen there does not seem to be a release at the git location you entered

Setup amber: +++fw_get -o crystal-0.23.1-1-linux-x86_64.tar.gz https://github.com/crystal-lang/crystal/releases/download/0.23.1/crystal-0.23.1-1-linux-x86_64.tar.gz
Setup amber: +++curl -sL -o crystal-0.23.1-1-linux-x86_64.tar.gz https://github.com/crystal-lang/crystal/releases/download/0.23.1/crystal-0.23.1-1-linux-x86_64.tar.gz
Setup amber: +++:
Setup amber: +++sleep 30
Setup amber: +++kill 15927
Setup amber: +++trap 'kill $!' SIGTERM
Setup amber: +++fw_untar crystal-0.23.1-1-linux-x86_64.tar.gz
Setup amber: +++echo 'Running '\''tar xf crystal-0.23.1-1-linux-x86_64.tar.gz'\''...please wait'
Setup amber: Running 'tar xf crystal-0.23.1-1-linux-x86_64.tar.gz'...please wait
Setup amber: +++tar xf crystal-0.23.1-1-linux-x86_64.tar.gz
Setup amber: tar: This does not look like a tar archive

@RX14
Copy link
Copy Markdown
Contributor

RX14 commented Sep 10, 2017

The problem is that the package release number this time is 3 not 1.

@drujensen
Copy link
Copy Markdown
Contributor Author

@RX14 @nbrady-techempower @sdogruyol I fixed the package to 3 and ran in the vagrant instance to verify this worked. Should be fixed now.

@nbrady-techempower is there a way to update to llvm to 3.9? If not, we will need to add a flag to all the crystal projects so they will compile. --no-debug

@RX14
Copy link
Copy Markdown
Contributor

RX14 commented Sep 10, 2017

@drujensen no, you'll need to use the --no-debug workaround.

@drujensen
Copy link
Copy Markdown
Contributor Author

@RX14 ok, thx. I created #2966 for all 3 projects.

@drujensen
Copy link
Copy Markdown
Contributor Author

@RX14 moved them over here since they are dependent on this update.

@faustinoaq
Copy link
Copy Markdown
Contributor

faustinoaq commented Sep 11, 2017

@drujensen @sdogruyol I think we should update crystal & crystal-frameworks synchronously

  1. Ensure crystal is latest version
  2. All crystal test should be updated both shard.yml and shard.lock to avoid shards update error. Well, thats reason why !.shard.lock is in our .gitignore
  3. If a framework/library is removed ensure to modify .travis.yml too.

So, I think with these steps we can avoid dependent PR like:

@drujensen
Copy link
Copy Markdown
Contributor Author

@faustinoaq both will be merged quickly and shards are not dependent on the language upgrade. No need to hold this up.

@nbrady-techempower I believe this is ready to go.

@NateBrady23 NateBrady23 merged commit 170c423 into TechEmpower:master Sep 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants