fix(apple-photos): review-sweep fixes from PR #91 bot analysis#107
Merged
Conversation
- --edited on export now queries all matching photos and prefers the edited file path at copy time (was incorrectly filtering to only-edited photos at the DB level, silently excluding non-edited photos) - --movies and --newest-first on export now use BooleanOptionalAction so users can pass --no-movies / --no-newest-first to opt out (was store_true + default=True, making them permanent no-ops with no opt-out path) - Bump apple-photos skill to 0.1.1 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
TechNickAI
added
review-sweep
4 tasks
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #91 (
feat: add apple-photos skill), addressing real bugs caught by Cursor and Codex review bots.--editedon export silently excluded non-edited photos —QueryOptions(edited=True)was filtering at the DB level beforecmd_export's "prefer edited path" logic ran, so non-edited photos were never seen. Fixed by passingskip_edited_filter=Truetobuild_query_optionsfromcmd_export.--movies/--newest-firstexport flags were un-toggleable no-ops —action="store_true"+default=Truemakes the value permanentlyTruewith no opt-out. Switched toBooleanOptionalActionto enable--no-movies/--no-newest-first.One Codex suggestion was declined (P2 — "HAS_OSXPHOTOS check is wrong"): the bot misread the code ordering.
find_specruns on line 21, before the mock injection on lines 26–28. Replied with explanation and 👎 reaction.Test plan
apple-photos export /dest --no-moviesnow excludes movies (previously impossible)apple-photos export /dest --editednow exports all matching photos, using edited version where available (previously silently dropped non-edited photos)apple-photos export /destunchanged — movies on, newest first, all photos🤖 Generated with Claude Code