Fix apple-photos export --edited to prefer instead of filter#99
Closed
TechNickAI wants to merge 1 commit into
Closed
Fix apple-photos export --edited to prefer instead of filter#99TechNickAI wants to merge 1 commit into
TechNickAI wants to merge 1 commit into
Conversation
The --edited flag on export was documented as "prefer edited versions" but was incorrectly filtering out all non-edited photos via QueryOptions. This fix adds a filter_edited parameter to build_query_options() that allows export to disable the filter while still using the flag as a preference in the source selection logic. Now export includes all photos and just prefers edited versions when available, matching the documented behavior. Addresses cursor[bot] feedback on PR #91. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
TechNickAI
added
review-sweep
Owner
Author
|
Superseded by #107 (merged) — same fix with cleaner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
--editedflag behavior on theapple-photos exportcommand. Previously it filtered out all non-edited photos (viaQueryOptions.edited=True), contradicting the "prefer edited versions" documentation. Now it includes all matching photos and uses the flag only to select which version to export.What Changed
filter_editedparameter tobuild_query_options()(defaultTruefor backward compatibility)filter_edited=Falseto disable the upstream filter--editedflag still works as intended in the source selection logic (line 168)Test Plan
--editednow includes non-edited photos (just prefers edited versions when available)--edited)Context
Addresses valid feedback from cursor[bot] on PR #91 (comment #3107030964).
🤖 Generated via /address-pr-comments skill