Add CompanyName filter to SearchCompaniesForAdmin endpoint #118

Copilot · 2025-06-17T05:18:15Z

This PR introduces a dedicated CompanyName filter parameter to the Search Companies endpoint for admin users, providing more precise filtering capabilities for the frontend.

Changes Made

Core Implementation

Added CompanyName property to SearchCompaniesForAdminQueryParams with default empty string
Added HasCompanyNameFilter() helper method following the same pattern as existing filters
Updated handler logic to apply company name filtering when the parameter is provided
Added proper using statements for extension method availability

API Usage

The endpoint now supports the following filtering options:

# Filter by company name only
GET /api/companies/for-admin?CompanyName=Microsoft

# Combine with existing search functionality  
GET /api/companies/for-admin?SearchQuery=Tech&CompanyName=Microsoft

# Existing SearchQuery functionality remains unchanged
GET /api/companies/for-admin?SearchQuery=Technology

Key Features

Case-insensitive filtering: Both filters use consistent lowercase comparison
Partial matching: Uses Contains() for flexible search behavior
Independent filters: CompanyName works independently or combined with SearchQuery
Backward compatibility: All existing functionality preserved
Proper validation: Empty/null values are handled correctly using the helper method

Test Coverage

Added comprehensive test suite covering:

CompanyName filter functionality
SearchQuery filter functionality (validation)
Combined filter scenarios
Case insensitivity validation
Empty filter handling
No filter scenarios

Files Changed

SearchCompaniesForAdminQueryParams.cs: Added CompanyName property and helper method (5 lines added)
SearchCompaniesForAdminHandler.cs: Added filtering logic and using statement (3 lines added)
SearchCompaniesForAdminHandlerTests.cs: New comprehensive test suite

Technical Notes

The implementation follows the established pattern used in SearchUsersForAdmin, ensuring consistency across the codebase. The filtering logic uses Entity Framework's When extension method for conditional query building, maintaining optimal query performance.

Fixes #117.

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: maximgorbatyuk <13348685+maximgorbatyuk@users.noreply.github.com>

maximgorbatyuk · 2025-06-17T05:30:49Z

src/Web.Api/Features/Companies/SearchCompaniesForAdmin/SearchCompaniesForAdminHandler.cs

+        var companyNameFilter = request.CompanyName?.Trim().ToLowerInvariant();
        var companies = await _context.Companies
            .AsNoTracking()
            .When(searchQuery?.Length >= 2, x => x.Name.ToLower().Contains(searchQuery))


Please remove this SearchQuery field from the request

Removed the SearchQuery field from the request as requested. The endpoint now follows the same pattern as SearchUsersForAdmin, using only specific named filters (CompanyName). Commit: 51eff54

Co-authored-by: maximgorbatyuk <13348685+maximgorbatyuk@users.noreply.github.com>

maximgorbatyuk · 2025-06-17T05:51:06Z

....Api.Tests/Features/Companies/SearchCompaniesForAdmin/SearchCompaniesForAdminHandlerTests.cs

@@ -0,0 +1,121 @@
+using System.Collections.Generic;


pipeline is broken. Analyze and fix

Fixed the pipeline issues caused by StyleCop violations in the test file. The build now passes successfully. Commit: 8b8e562

Co-authored-by: maximgorbatyuk <13348685+maximgorbatyuk@users.noreply.github.com>

coderabbitai · 2025-06-17T06:01:56Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Initial plan for issue

8c3e544

Copilot AI assigned Copilot and maximgorbatyuk Jun 17, 2025

Copilot started work on behalf of maximgorbatyuk June 17, 2025 05:18 View session

maximgorbatyuk mentioned this pull request Jun 17, 2025

Add Search by Company Name field to the Companies admin page Techinterview-space/frontend#85

Closed

Copilot AI and others added 2 commits June 17, 2025 05:26

Add CompanyName filter to SearchCompaniesForAdmin endpoint

bb2348c

Co-authored-by: maximgorbatyuk <13348685+maximgorbatyuk@users.noreply.github.com>

Add missing Infrastructure.Extensions using statement

7392cd0

Co-authored-by: maximgorbatyuk <13348685+maximgorbatyuk@users.noreply.github.com>

maximgorbatyuk reviewed Jun 17, 2025

View reviewed changes

Copilot AI changed the title ~~[WIP] Introduce filter by company name in the Search Companies endpoint for admin~~ Add CompanyName filter to SearchCompaniesForAdmin endpoint Jun 17, 2025

Copilot AI requested a review from maximgorbatyuk June 17, 2025 05:32

Copilot finished work on behalf of maximgorbatyuk June 17, 2025 05:32

Copilot started work on behalf of maximgorbatyuk June 17, 2025 05:32 View session

Remove SearchQuery field and functionality as requested

51eff54

Co-authored-by: maximgorbatyuk <13348685+maximgorbatyuk@users.noreply.github.com>

Copilot finished work on behalf of maximgorbatyuk June 17, 2025 05:37

maximgorbatyuk reviewed Jun 17, 2025

View reviewed changes

Copilot started work on behalf of maximgorbatyuk June 17, 2025 05:51 View session

Fix StyleCop violations in SearchCompaniesForAdminHandlerTests

8b8e562

Co-authored-by: maximgorbatyuk <13348685+maximgorbatyuk@users.noreply.github.com>

Copilot finished work on behalf of maximgorbatyuk June 17, 2025 05:56

maximgorbatyuk marked this pull request as ready for review June 17, 2025 06:01

maximgorbatyuk approved these changes Jun 17, 2025

View reviewed changes

maximgorbatyuk merged commit aa8cd57 into main Jun 17, 2025
3 checks passed

maximgorbatyuk deleted the copilot/fix-117 branch June 17, 2025 06:03

Copilot AI mentioned this pull request Jun 17, 2025

Add Search by Company Name field to the Companies admin page Techinterview-space/frontend#86

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add CompanyName filter to SearchCompaniesForAdmin endpoint #118

Add CompanyName filter to SearchCompaniesForAdmin endpoint #118

Uh oh!

Copilot AI commented Jun 17, 2025 •

edited

Loading

Uh oh!

maximgorbatyuk Jun 17, 2025

Uh oh!

Copilot AI Jun 17, 2025

Uh oh!

maximgorbatyuk Jun 17, 2025

Uh oh!

maximgorbatyuk Jun 17, 2025

Uh oh!

Copilot AI Jun 17, 2025

Uh oh!

coderabbitai bot commented Jun 17, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add CompanyName filter to SearchCompaniesForAdmin endpoint #118

Add CompanyName filter to SearchCompaniesForAdmin endpoint #118

Uh oh!

Conversation

Copilot AI commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

Core Implementation

API Usage

Key Features

Test Coverage

Files Changed

Technical Notes

Uh oh!

maximgorbatyuk Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

maximgorbatyuk Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

maximgorbatyuk Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot commented Jun 17, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jun 17, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)