HEEDLS-631 Add migration to reduce the GroupDescription column length #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public override void Up() | ||
| { | ||
| Execute.Sql("UPDATE Groups SET GroupDescription = LEFT(GroupDescription, 1000)"); | ||
| Alter.Table("Groups").AlterColumn("GroupDescription").AsString(1000).Nullable(); |
There was a problem hiding this comment.
Does this specify the number of characters or the number of bytes?
There was a problem hiding this comment.
it'll set it to a nvarchar(1000)
There was a problem hiding this comment.
Grand. Are you confident you can fit a 1000-character string in there? I'm slightly hazy on this, especially where character encodings are concerned, but if you're confident / have tested then merge away.
There was a problem hiding this comment.
Yes, I've put a 1000 character string xxxxxxxxx... into mine, and it truncated the longer one down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://softwiretech.atlassian.net/browse/HEEDLS-631
Description
Migration to reduce the size of Groups.GroupDescription from nvarchar(max) to nvarchar(1000), truncating any values over this limit (there should hopefully still be none by the time this makes it live)
Screenshots
N/A
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: