Skip to content

HEEDLS-631 Add migration to reduce the GroupDescription column length #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2021
Merged

HEEDLS-631 Add migration to reduce the GroupDescription column length #712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions DigitalLearningSolutions.Data.Migrations/202111081225_ReduceGroupsGroupDescriptionLength.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
namespace DigitalLearningSolutions.Data.Migrations
{
using FluentMigrator;

[Migration(202111081225)]
public class ReduceGroupsGroupDescriptionLength : Migration
{
public override void Up()
{
Execute.Sql("UPDATE Groups SET GroupDescription = LEFT(GroupDescription, 1000)");
Alter.Table("Groups").AlterColumn("GroupDescription").AsString(1000).Nullable();
Copy link
Contributor

@SteveJacksonSoft SteveJacksonSoft Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this specify the number of characters or the number of bytes?

Copy link
Contributor Author

@AlexJacksonDS AlexJacksonDS Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'll set it to a nvarchar(1000)

Copy link
Contributor

@SteveJacksonSoft SteveJacksonSoft Nov 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grand. Are you confident you can fit a 1000-character string in there? I'm slightly hazy on this, especially where character encodings are concerned, but if you're confident / have tested then merge away.

Copy link
Contributor Author

@AlexJacksonDS AlexJacksonDS Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've put a 1000 character string xxxxxxxxx... into mine, and it truncated the longer one down.

}

public override void Down()
{
Alter.Table("Groups").AlterColumn("GroupDescription").AsString(int.MaxValue).Nullable();
}
}
}