Skip to content

Conversation

@AnjuJose011
Copy link
Contributor

JIRA link

TD-###

Description

Describe what has changed and how that will affect the app. If relevant, add references to the resources you used. Use this as your opportunity to highlight anything odd and give people context around particular decisions.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

akdalin-hee and others added 30 commits January 17, 2024 17:46
…t it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic
Bring RC changes to release/Phoenix
…ning-accessibility-fix

Move filter-summary outside of details tag. Amend itss styling so that it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic
Missed this file part of the Azure to GitHub migration
…ning-accessibility-fix

Move filter-summary outside of details tag. Amend itss styling so that it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic
This reverts commit 658632b.
…/TD-3675-Fix-Issues-UnknownError-ResourceDetailsPage

Develop/fixes/td 3675 fix issues unknown error resource details page
…/TD-3688-Missing-In-Progress-resources-in-the-My-Accessed-Learning-tray

TD-3688: Fixed missing In progress resources in the My Accessed Learning tray issue
…/TD-3726-Video-not-recording-progress-properly-and-returning-unknownerror

Develop/fixes/td 3726 video not recording progress properly and returning unknown error
…op/Fixes/TD-3726-Video-not-recording-progress-properly-and-returning-unknownerror"

This reverts commit 23732c2.
…/TD-3744-Jobrolewithslashincauseserrorduringregistration

TD-3744-Job role with slash in causes error during registration
AnjuJose011 and others added 29 commits March 14, 2024 12:00
…/TD-3726_

TD-3726 Updated cert check for media resources
…/TD-3744-JobRoleErrorFix

Defect Fixes-TD-3744-Job role with slash in causes error during registration
…/TD-3947-ReplaceFeedbackForm

TD-3947-Replace user research links for participant recruitment on the Learning Hub
…/TD-3688-Missing-In-Progress-resources-in-the-My-Accessed-Learning-tray-fix

TD-3688: Issue fix for Completed status resource showing in In progress tray
…/TD-3744-JobRoleError

TD-3744-Job role with slash in causes error during registration
…/Td-3744-AddedSpecialcharinstring

added special characters
…/TD-3950

TD-3950 bookmark partial view error bugfix
…ning-accessibility-fix

Move filter-summary outside of details tag. Amend itss styling so that it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic
…ystem also includes DigitalLearningSolutionsSso external user system
…/TD-3977-ErrorFix-DLS

TD-3977-DLS users receiving "Your account cannot be validated" error when accessing LH through SSO
…/TD-3991

TD-3991 Fix for certificate display for web and generic file resource
…/accessibility-3158-3159-fixes

Reintroduce TD-3158 and TD-3159 fixes
…/TD-3993

TD-3993 video duration text bugfix
…/accessibility-3158-3159-fixes

Make buttons readable to Windows Narrator. Update NHS Learning Hub lo…
@AnjuJose011 AnjuJose011 merged commit a686ba9 into master Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants