Make public site deployment explicit#88
Conversation
Deploying secopsai with
|
| Latest commit: |
66364af
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3a2de0ca.secopsai.pages.dev |
| Branch Preview URL: | https://codex-deploy-public-site-ins.secopsai.pages.dev |
Deploying website with
|
| Latest commit: |
66364af
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://782c3404.website-bks.pages.dev |
| Branch Preview URL: | https://codex-deploy-public-site-ins.website-bks.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66364afe1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| echo "${installer} did not return a POSIX shell installer" >&2 | ||
| exit 1 | ||
| fi | ||
| grep -F "$marker" "$output" >/dev/null |
There was a problem hiding this comment.
When an installer changes without changing these release markers—for example, a fix to install.sh while remaining on v1.0.0—the previous deployment has the same shebang and marker, so this check succeeds even if the apex domain still serves stale content or points at the wrong deployment. The SHA query only makes the request URL unique; it does not prove the response came from that commit. Compare the downloaded body with website/${installer} or its digest instead.
Useful? React with 👍 / 👎.
1 participant
Summary
website/directory to thewebsiteCloudflare Pages projectWhy
The Cloudflare Git integration reported success but the custom domain still returned its SPA fallback for the new Hermes installer. This workflow makes the deployment directory and post-deploy acceptance checks explicit.
Verification