P03: implement canonical Design System foundation - #13
Merged
Conversation
Techshrr
marked this pull request as ready for review
August 20, 2026 15:13
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GoJet V10 / P03 — Design System
Refs #1
Closes #12
Final implementation scope
tokens.jsonsynchronizationtokens.json-> CSS / TypeScript / design-variable generation@gojet/uiaccessible controls, overlay, navigation, data, feedback and layout foundationsAuthority rule
The approved
GJ-V10-DS-GREENFIELD-2026-08-20document remains the design approval authority.frontend/packages/tokens/src/tokens.jsonis the canonical runtime token source synchronized from that authority; generated artifacts may not be manually edited.G2 reviewed evidence
Reviewed implementation:
88465e9f5b7e25968ede98c19f77f9a9908e709a9412357875ef3da8bf0b0bcaf50d98e3953036c7d61f8c1a6805c612f1853ee3c12a337aaeSigned exact-head revalidation
Signed head:
cf00b46791d22f3a1c4a41e2db1bbf2b74302316941244381774077031ab0a7fc1fc046f9321de87fcc09e0ea996722e0c520c9c17bc07a4feReview history retained
Before sign-off, manual evidence review caught and corrected two issues that automated tests alone did not expose: missing Simplified Chinese fonts on the Ubuntu evidence runner, and a non-modal dialog evidence state. The current workflow hard-fails unless
Noto Sans SCresolves to a Simplified Chinese Noto family, and canonical captures now use a true modalshowModal()state with backdrop/focus.Final status
READY TO MERGE — G2 PASS
P0/P1 defects: 0 open
DECISION REQUIRED: 0