ANDROID-17148 -- Fix double extension when generating files in Snapshot Testing library #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n log file is creating
dhonti-axpe
requested review from
a team,
jeslat and
juangardi21
and removed request for
a team
Contributor
|
After moving Loggerazzi fixes to this library, we introduced some bugs. I've done two changes:
|
jeslat
approved these changes
Nov 26, 2025
pmartinbTEF
reviewed
Nov 26, 2025
| val goldenFile = directories.context.assets.open("${directories.goldenFilesDir}/${testName}.txt") | ||
| val goldenStringLogs = String(goldenFile.readBytes()).takeIf { it.isNotEmpty() }?.split("\n") ?: emptyList() | ||
| val comparison = compare(goldenStringLogs) | ||
| writeRecordedLogsToFile(fileName, comparison.recordedLogs) |
There was a problem hiding this comment.
Should it be reviewed screenshot tests too? they have similar logic
Contributor
There was a problem hiding this comment.
I've double-checked it, the ScreenshotsRule is saving the screenshots before failing the test so there isn't any problem in that case https://github.com/Telefonica/android-snaptesting/blob/main/android-snaptesting/src/main/java/com/telefonica/androidsnaptesting/screenshots/ScreenshotsRule.kt#L99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
ANDROID-17148
🥅 What's the goal?
Fix an issue in the library that generates recorded log files with a duplicated .txt extension (e.g.
TestClass_testMethod.txt.txt).This duplicated extension breaks the comparison against the corresponding golden files, which are correctly defined with a single .txt extension.
🚧 How do we do it?
To fix this behaviour, it was updated the file-naming logic inside
LogsRuleso that the temporary log file generated during test execution no longer includes the .txt suffix.This allows the Gradle plugin (
AndroidSnaptestingPlugin) to correctly rename the latest generated recording to .txt without producing a double extension.Implementation steps:
.txtsuffix from the temporary filename created inLogsRule.${testName}.txt.${System.nanoTime()}${testName}.${System.nanoTime()}<testName>.txt), ensuring full backwards compatibility.<testName>.txtwithout duplication..txt.txt.📘 Documentation changes?
🧪 How can I test this?
LogsRule, for example:./gradlew :app:connectedDebugAndroidTestapp/build/reports/androidTests/connected/debug/androidSnapTesting/recorded/<TestClass>_<method>.txt