Skip to content

Conversation

@dhidalgofadrique
Copy link
Contributor

Updated triggerPinOrBiometricAuthentication message description in README specifying responses

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the README documentation for the triggerPinOrBiometricAuthentication method to provide clearer information about its return values in different scenarios.

Key Changes:

  • Added specification of return values (USER_ENABLED_AUTHENTICATION and USER_AUTHENTICATED) for different authentication states

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dhidalgofadrique dhidalgofadrique marked this pull request as ready for review November 10, 2025 10:40
will be asked and if it goes right, the setting will remain unchanged
(enabled) and the method will return `USER_AUTHENTICATED`
- If the device doesn't have any authentication configured, the method will
return `DEVICE_HAS_NO_AUTHENTICATION` as result.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there isn't still an extra case: LAST_AUTHENTICATION_STILL_VALID?

see https://github.com/Telefonica/webview-bridge/blob/master/src/post-message.ts#L340-L343

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Updated in 20f04d5

@atabel atabel enabled auto-merge (squash) November 24, 2025 09:52
@atabel atabel merged commit d58ea69 into master Nov 24, 2025
2 checks passed
@atabel atabel deleted the dhidalgo-update-triggerPinOrBiometricAuthentication-readme branch November 24, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants