-
Notifications
You must be signed in to change notification settings - Fork 10
Updated triggerPinOrBiometricAuthentication README description #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated triggerPinOrBiometricAuthentication README description #235
Conversation
…tricAuthentication message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the README documentation for the triggerPinOrBiometricAuthentication method to provide clearer information about its return values in different scenarios.
Key Changes:
- Added specification of return values (
USER_ENABLED_AUTHENTICATIONandUSER_AUTHENTICATED) for different authentication states
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| will be asked and if it goes right, the setting will remain unchanged | ||
| (enabled) and the method will return `USER_AUTHENTICATED` | ||
| - If the device doesn't have any authentication configured, the method will | ||
| return `DEVICE_HAS_NO_AUTHENTICATION` as result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there isn't still an extra case: LAST_AUTHENTICATION_STILL_VALID?
see https://github.com/Telefonica/webview-bridge/blob/master/src/post-message.ts#L340-L343
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Updated in 20f04d5
…metricAuthentication doc
Updated
triggerPinOrBiometricAuthenticationmessage description in README specifying responses