fix: composite domain-answer key (#7) + transcript redaction (#9) - #11
Merged
Conversation
#7 — DomainAnswerStore keyed answers by question TEXT only, so two different files asking the same question (e.g. "What is the grace period?") collapsed to one answer; answering it in file A silently unblocked file B with A's answer. hashQuestion now takes (filePath, text) and hashes the composite. Same wording in a different file is a distinct question again. #9 — Captured transcripts wrote full prompts/responses to disk unredacted; they can carry pulled-in source and secrets. New redactSecrets() masks known token shapes (sk-ant-, sk-/sk-proj-, ghp_/gho_/…, github_pat_, AKIA/ASIA, AIza, xox*, Bearer values, and SECRET_NAME=value assignments). instrumentLLMCaller/CodexCaller redact by default (opt out with { redact: false }); the events file is created mode 0600. Tests: 387 → 400. New: hashQuestion file-scoping + path-normalization; redactSecrets per token shape + non-secret passthrough; instrumented callers redact by default and honor redact:false. No skips. Refs Codex review #7, #9 (private KB).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the two correctness/privacy mediums from the Codex review.
#7 — Domain answers collided across files.
DomainAnswerStorekeyed answers by question text only, so two different files asking "What is the grace period?" shared one answer — answering it in file A silently unblocked file B with A's answer.hashQuestionnow takes(filePath, text)and hashes the composite (path normalized; text still whitespace/case-insensitive). Same wording in a different file is a distinct question again.#9 — Transcripts written unredacted. Captured prompts/responses can carry pulled-in source and secrets. New
redactSecrets()masks known token shapes (sk-ant-,sk-/sk-proj-,ghp_/gho_/…,github_pat_,AKIA/ASIA,AIza,xox*, Bearer values, andSECRET_NAME=valueassignments).instrumentLLMCaller/instrumentCodexCallerredact by default (opt out with{ redact: false }); the events file is created mode0600.Tests
387 → 400. New:
hashQuestionfile-scoping + path normalization;redactSecretsper token shape + non-secret passthrough; instrumented callers redact by default and honorredact: false. Build + typecheck clean; no skips. (Validated on local-disk copy.)🤖 Generated with Claude Code