feat: implement virtual channels initialization for PipeWire - #2
Merged
Conversation
RiceaRaul
commented
Jul 6, 2025
RiceaRaul
commented
Contributor
- Add init_virtual_channels function to create game and chat sinks
- Automatically link virtual sinks to default audio output
- Create missing sinks only if they don't already exist
- Improve error handling and logging for sink operations
- Add init_virtual_channels function to create game and chat sinks - Automatically link virtual sinks to default audio output - Create missing sinks only if they don't already exist - Improve error handling and logging for sink operations
RiceaRaul
requested review from
SFlrn22 and
Copilot
and removed request for
Copilot
July 6, 2025 21:53
There was a problem hiding this comment.
Pull Request Overview
This PR adds initialization logic for virtual game/chat audio channels in PipeWire, ensuring missing sinks are auto-created and linked to the system’s default output.
- Introduce
get_default_sink,init_virtual_channels, and helper routines for sink creation and linking inpipewire.rs - Update Tauri setup in
lib.rsto invokeinit_virtual_channelsat startup - Define a new
SinkConfigstruct andSINK_CONFIGSarray inaudio/mod.rs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src-tauri/src/system/pipewire.rs | Added virtual sink initialization and linking |
| src-tauri/src-tauri/src/lib.rs | Hooked init_virtual_channels into Tauri setup |
| src-tauri/src/audio/mod.rs | Defined SinkConfig and SINK_CONFIGS constants |
SFlrn22
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.