Skip to content

fix(core): fix invalid animation crash#4117

Merged
wwwcg merged 1 commit intoTencent:mainfrom
etkmao:bugfix/animation_crash20241107
Nov 7, 2024
Merged

fix(core): fix invalid animation crash#4117
wwwcg merged 1 commit intoTencent:mainfrom
etkmao:bugfix/animation_crash20241107

Conversation

@etkmao
Copy link
Copy Markdown
Collaborator

@etkmao etkmao commented Nov 7, 2024

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@etkmao etkmao requested a review from wwwcg November 7, 2024 08:37
@etkmao etkmao requested a review from ilikethese as a code owner November 7, 2024 08:37
@github-actions github-actions Bot added dom: animation size: xs Denotes a PR that changes 0-9 lines labels Nov 7, 2024
@hippy-service
Copy link
Copy Markdown

hippy-service Bot commented Nov 7, 2024

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

Copy link
Copy Markdown
Collaborator

@wwwcg wwwcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etkmao etkmao enabled auto-merge (squash) November 7, 2024 08:49
@wwwcg wwwcg disabled auto-merge November 7, 2024 09:35
@wwwcg wwwcg merged commit b9006fa into Tencent:main Nov 7, 2024
wwwcg pushed a commit to wwwcg/Hippy that referenced this pull request Nov 7, 2024
wwwcg pushed a commit that referenced this pull request Nov 7, 2024
Cyunong pushed a commit to Cyunong/Hippy that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dom: animation size: xs Denotes a PR that changes 0-9 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants