fix(docreader): restore optional XLSX header context - #2314
Merged
lyingbug merged 2 commits intoJul 28, 2026
Conversation
2 tasks
Normalize Excel file types when resolving parser rules and applying the xlsx_first_row_as_header override for both xlsx and xls. Skip the override for non-builtin engines, unify legacy XLS parsing with the XLSX default path, and extend tests for case handling and explicit false overrides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.7.1 built-in XLSX path treats row 1 as ordinary A/B/C data, leaving later rows without semantic column context.
Validation
go test ./internal/application/service -run 'TestEffectiveChunkingConfig_ResolveParserEngineFromOverrides|TestApplyParserRuleOverrides_XLSXFirstRowAsHeader' -count=1npm run build-onlygit diff --checkCloses #2310