fix(im): recover channels after leader lock loss - #2365
Merged
Conversation
March-77
marked this pull request as ready for review
July 28, 2026 09:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore an in-process recovery path when a WebSocket or long-poll IM runtime loses its Redis leader lease.
The renewal loop now stops the adapter and schedules the channel through the existing leader takeover loop. That loop already re-reads the durable channel row before reconnecting, preserving delete/disable/config freshness checks and the per-channel retry deduplication guard.
Root cause
wsLeaderRenewLoopcalledStopChanneland returned when renewal failed or ownership was lost. Only startup-time acquisition failures enteredwsLeaderRetryLoop, so an enabled Feishu WebSocket channel could remain inactive until the app restarted.Impact
Transient Redis renewal failures or lease replacement no longer leave enabled channels permanently stopped. Duplicate loss handling remains idempotent, and a channel deleted or disabled while waiting is not resurrected.
Testing
go test ./internal/im -run 'TestLeadershipLossStopsAdapterAndSchedulesRecovery|TestLeaderElectionFailsClosedWhenRedisUnavailable' -count=1git diff --checkFixes #2344