Refine user settings menu and access shortcuts - #2368
Merged
Conversation
lyingbug
marked this pull request as ready for review
July 28, 2026 03:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The avatar menu had accumulated an arbitrary subset of infrastructure settings while omitting peer settings, making it both long and incomplete. It also exposed management-labelled shortcuts to read-only users. This change gives the menu a clearer account/workspace purpose while preserving the complete settings navigation as the source of truth.
User impact
Users get direct Personal Settings and Workspace Settings entries. Owners and administrators retain relevant management shortcuts, while read-only users can still browse the corresponding pages through All Settings. System administrators keep a dedicated entry for the full administration group.
Validation
npm run build-onlynpx tsx --test src/config/settingsAccess.test.tsgit diff --checkKnown baseline issues outside this diff:
npm run type-checkreports existing errors insessionSidebarBuckets.ts,AgentEditorModal.vue, andSystemSettings.vuenpm testpasses 246 tests and retains 2 existing workspace-terminology failures in unrelated locale/docs content