fix(frontend): restore runtime queue i18n and guard against prune - #2529
Merged
Conversation
Re-add worker pool, queue, and task type labels dropped during locale cleanup, register dynamic key prefixes in the i18n audit, and add tests so check-i18n fails if they are removed again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pools,poolDescriptions,queueNames,queueDescriptions,tasks.taskTypes) in all four locale files; the task queue page was showing raw keys likecoreandchat_attachment.localeKeyAudit.tsso i18n prune/regenerate keeps these trees (they are built viate(\system.globalSettings.runtime.queueNames.${name}`)` and static analysis alone does not reference them).check-i18ncoverage listing every worker pool, queue, and task type key so future locale cleanup fails CI if any are removed.Test plan
npm run check-i18ninfrontend/