fix(Storage): prevent saving items with empty keys - #728
Merged
Conversation
Add validation to check if the key is empty or contains only whitespace before saving a storage item. Previously, clearing the key field and clicking save would create an invalid storage entry with an empty key. Fixes potential data inconsistency where storage items could be created with empty string keys, which are difficult to manage and can cause unexpected behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug Description
Previously, if a user cleared the key field in the storage editor and clicked save, vConsole would create a storage item with an empty key. These entries are:
Fix
Added validation in
onTapSavefunction that returns early if the key is empty or contains only whitespace, preventing the invalid save operation.Test Plan
Related Issues
Addresses potential user-reported issues with storage editor behavior.