fix(Network): store empty string for query params without values - #729
Merged
Conversation
When parsing URL query strings like 'a=1&c', parameters without values
(e.g., 'c') were being stored with the literal string 'undefined' instead
of an empty string. This fixes the behavior to store an empty string for
parameters that have no value.
For example:
- Before: { a: '1', c: 'undefined' }
- After: { a: '1', c: '' }
This aligns better with standard URL parameter handling where 'c' and 'c='
are typically treated the same way.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
genFormattedBodyinhelper.tsBug Description
When parsing URL query strings like
a=1&c, parameters without values (likec) were being stored with the literal string'undefined'instead of an empty string.Example:
a=1&c{ a: '1', c: 'undefined' }{ a: '1', c: '' }This is inconsistent with standard URL parameter handling where
candc=are typically treated the same way (both representing a parameter with an empty value).Fix
Changed the ternary operator in
genFormattedBodyto return an empty string ('') instead of the literal string'undefined'whenkv[1]is undefined.Test Plan
?a=1&c)cshows an empty string instead of 'undefined'Related Issues
Improves network request inspection accuracy.