fix(web): ship placeholder judge model so a clean clone resolves & runs - #4
Open
kongyoongkeong-lab wants to merge 1 commit into
Open
Conversation
The Web benchmark (configs/bench/wb-bench-web-v1.0.yaml) pins llm_judge.model: kimi-k2.7-think by default, but configs/models/** is gitignored (only _template.model.yaml is shipped). On a clean clone, resolve_manifest therefore fails every Web run with: llm_judge.model='kimi-k2.7-think' does not resolve to a model config at .../configs/models/kimi-k2.7-think.yaml All 70 Web tasks contain llm/vlm judge items, and the in-container CompositeVerifier raises when the verifier LLM route is not configured, so the Web track is currently unrunnable out of the box. Fix: un-ignore and ship configs/models/kimi-k2.7-think.yaml as an env-only placeholder (mirrors _template.model.yaml). Credentials still come from .env (KIMI_BASE_URL / KIMI_API_KEY). Real backends fill those two vars; the slug now resolves so the LLM/VLM judge route is wired up. The web bench default (enabled: true, model: kimi-k2.7-think) is left intact - this only restores the model file the default points at.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Web benchmark (
configs/bench/wb-bench-web-v1.0.yaml) pinsllm_judge.model: kimi-k2.7-thinkby default, butconfigs/models/**is gitignored (only_template.model.yamlships). On a clean clone,resolve_manifesttherefore fails every Web run with:All 70 Web tasks contain
llm/vlmjudge items, and the in-containerCompositeVerifierraises when the verifier LLM route is not configured (route_ready=False), so the Web track is currently unrunnable out of the box.Fix
configs/models/kimi-k2.7-think.yamlas an env-only placeholder (mirrors_template.model.yaml). Credentials still live in.env(KIMI_BASE_URL/KIMI_API_KEY); the file names only the env vars to read.enabled: true,model: kimi-k2.7-think) is left intact — this only restores the model file the default points at, so the LLM/VLM judge route resolves and the verifier stops raising.Users with a Moonshot/Kimi backend fill the two
.envvars and run as before. The slug now resolves cleanly; a missingKIMI_BASE_URLsurfaces a clear runtime error instead of a silent manifest-resolution failure.Test plan
resolve_manifestno longer reports the missing-model error for a Web job (model slug now resolves to a config).kimi-k2.7-think.yamltracks (gitignore exception added).Notes / alternatives considered
<model-slug>+enabled: falsepasses the resolver but breaks scoring: the verifier raises on the 70 tasks that require an LLM/VLM route. Keepingenabled: trueand restoring the model file is the minimal change that keeps the Web track actually runnable.kimi-k2.7-think.yaml(cp from_template)" in the README and relax the gitignore similarly — happy to adjust.