Skip to content

docs(statistics): 同步 BK-Vision 空间信息图表文档 - #765

Merged
dengyh merged 1 commit into
TencentBlueKing:masterfrom
dengyh:feat/bkvision-space-info-docs
Jun 26, 2026
Merged

docs(statistics): 同步 BK-Vision 空间信息图表文档#765
dengyh merged 1 commit into
TencentBlueKing:masterfrom
dengyh:feat/bkvision-space-info-docs

Conversation

@dengyh

@dengyh dengyh commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • 补充 BK-Vision 数据源需要访问 space_space 表的说明
  • 更新系统运营统计空间排行 Top 10 SQL,展示 app_code 和空间名称
  • 更新模板活跃度 Top 20 SQL,展示 app_code 和空间名称
  • 在部署 checklist 中增加空间元数据访问检查

Impact

仅文档变更,用于对齐已调整的 BK-Vision 图表配置;不影响运行时代码。

Checks

  • git diff --check -- docs/specs/2026-03-31-bkvision-statistics-dashboard-design.md
  • pre-commit: Check for merge conflicts passed; Python checks skipped because本次仅修改 Markdown 文档

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

纯文档变更,更新 BK-Vision 统计仪表盘设计文档中的 SQL 示例和部署 checklist。变更清晰、范围收敛,无运行时代码影响。

亮点

  • SQL 使用 COALESCELEFT JOIN 处理空间信息缺失情况,考虑周全
  • 部署 checklist 补充了 space_space 表访问权限确认步骤

⚠️ 一个小建议

  • 第 179 行说明了跨库场景需使用带库名的表名(如 <bkflow_db>.space_space),但 Panel 7 和 Panel 14 的 SQL 示例中直接写了 LEFT JOIN space_space s。建议在 SQL 旁加注释说明 "若跨库部署,需替换为带库名写法",或直接在示例中使用参数化表名,保持文档自洽。

整体 LGTM,无阻塞问题。

@dengyh
dengyh merged commit e48e72b into TencentBlueKing:master Jun 26, 2026
8 checks passed
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.10%. Comparing base (9a63478) to head (0595709).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #765   +/-   ##
=======================================
  Coverage   83.10%   83.10%           
=======================================
  Files         307      307           
  Lines       18167    18167           
=======================================
  Hits        15098    15098           
  Misses       3069     3069           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants